Point to lifetime spans on lifetime errors #51862
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| let mut sp = cm.def_span(self.hir.span(node)); | ||
| if let Some(generics) = self.hir.get_generics(scope) { | ||
| for param in &generics.params { | ||
| if param.name.name().as_str() == br.name.as_str() { |
There was a problem hiding this comment.
This loop feels like something that occurs more often (e.g. in lowering code or other diagnostics). Maybe pull it out into a method on Generics and do a quick grep around the source to see if any other places could benefit from an fn(&Generics, Name) -> Option<&Param>
There was a problem hiding this comment.
I made a cursory look for other possible uses but I couldn't any. I'm sure I'll find some while working on something else down the line, though.
This comment has been minimized.
This comment has been minimized.
| ), | ||
| ty::ReEarlyBound(ref br) => { | ||
| let mut sp = cm.def_span(self.hir.span(node)); | ||
| if let Some(generics) = self.hir.get_generics(scope) { |
There was a problem hiding this comment.
I agree with @oli-obk that we should not "open code" this loop but rather extract a helper. Bonus points for finding other code to use it =)
| let mut sp = cm.def_span(self.hir.span(node)); | ||
| if let Some(generics) = self.hir.get_generics(scope) { | ||
| for param in &generics.params { | ||
| if param.name.name().as_str() == name.as_str() { |
There was a problem hiding this comment.
If nothing else, the same loop seems to be down here?
nikomatsakis
added
S-waiting-on-author
|
Helper added. |
This comment has been minimized.
This comment has been minimized.
estebank
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8449c5a has been approved by |
bors
added
S-waiting-on-bors
…akis Point to lifetime spans on lifetime errors
Point to lifetime spans on lifetime errors
|
☀️ Test successful - status-appveyor, status-travis |
No description provided.