stabilize lint handling in rustdoc

[QuietMisdreavus]

When #51732 added CLI flags to manipulate lints in rustdoc, they were added as unstable flags. This made sense as they were new additions, but since they mirrored the flags that rustc has, it's worth considering them to not need an unstable period.

Stabilizing them also provides the opportunity for a critical fix: allowing Cargo to pass --cap-lints allow when documenting dependencies, the same as when it compiles them.

r? @rust-lang/rustdoc

[QuietMisdreavus]

@rfcbot merge

[rfcbot]

Team member @QuietMisdreavus has proposed to merge this. The next step is review by the rest of the tagged teams:

• @GuillaumeGomez
• @QuietMisdreavus
• @ollie27
• @onur
• @steveklabnik

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[GuillaumeGomez]

This is not exactly mirrored from rustc, far from that. But if you're ok, then I have no problem stabilizing it. :)

[QuietMisdreavus]

What makes it different from rustc? The flags themselves are the same, are they not?

[GuillaumeGomez]

The flags are the same, the code behind isn't at all. In rustdoc, we have an extra handling for lints we don't have for rustc. By default, all lints are disabled, but it changes if you use one of those flags (for this lint only though).

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[GuillaumeGomez]

@bors: r+

[bors]

📌 Commit 8f1ebbc has been approved by GuillaumeGomez

[bors]

⌛ Testing commit 8f1ebbc with merge 113cbd2594ab412f9a4c1dc1590b5aa00df0c8f4...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:33:17] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "cargotest", path: "src/tools/cargotest", mode: ToolBootstrap, is_ext_tool: false, extra_features: [] } -- 1.323
[01:33:17] testing https://github.com/servo/webrender
[01:33:17] Initialized empty Git repository in /checkout/obj/build/ct/webrender/.git/
[01:33:17] fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
[01:34:13] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com
[01:34:13] thread 'main' panicked at 'assertion failed: status.success()', tools/cargotest/main.rs:128:13
[01:34:13] 
[01:34:13] 
[01:34:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:34:13] expected success, got: exit code: 101
[01:34:13] expected success, got: exit code: 101
[01:34:13] 
[01:34:13] 
[01:34:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:34:13] Build completed unsuccessfully in 0:36:45
[01:34:13] make: *** [check-aux] Error 1
[01:34:13] Makefile:60: recipe for target 'check-aux' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:29341810
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:13d6329e:start=1532068737457467269,finish=1532068737464644466,duration=7177197
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0245d078
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1197744e
travis_time:start:1197744e
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0229a188
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[pietroalbini]

@bors retry travis-ci/travis-ci#9696

[bors]

⌛ Testing commit 8f1ebbc with merge 878dd0b...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 878dd0b to master...

[ollie27]

Where are the tests for these command line arguments?