-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically expand section if url id point to one of its component #53094
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 5, 2018
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
automatic-expand
branch
from
August 5, 2018 17:44
dd4d57c
to
c70eb4b
Compare
@bors: r+ rollup |
📌 Commit c70eb4b has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 8, 2018
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Automatically expand section if url id point to one of its component Fixes rust-lang#52517. r? @nrc
This was referenced Aug 8, 2018
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Automatically expand section if url id point to one of its component Fixes rust-lang#52517. r? @nrc
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Automatically expand section if url id point to one of its component Fixes rust-lang#52517. r? @nrc
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 9, 2018
Automatically expand section if url id point to one of its component Fixes rust-lang#52517. r? @nrc
bors
added a commit
that referenced
this pull request
Aug 9, 2018
Rollup of 15 pull requests Successful merges: - #52773 (Avoid unnecessary pattern matching against Option and Result) - #53082 (Fix doc link (again)) - #53094 (Automatically expand section if url id point to one of its component) - #53106 (atomic ordering docs) - #53110 (Account for --remap-path-prefix in save-analysis) - #53116 (NetBSD: fix signedess of char) - #53179 (Whitelist wasm32 simd128 target feature) - #53183 (Suggest comma when missing in macro call) - #53207 (Add individual docs for rotate_{left, right}) - #53211 ([nll] enable feature(nll) on various crates for bootstrap) - #53214 ([nll] enable feature(nll) on various crates for bootstrap: part 2) - #53215 (Slightly refactor syntax_ext/format) - #53217 (inline some short functions) - #53219 ([nll] enable feature(nll) on various crates for bootstrap: part 3) - #53222 (A few cleanups for rustc_target)
Ms2ger
reviewed
Aug 10, 2018
if (hash !== null) { | ||
var elem = document.getElementById(hash); | ||
if (elem && elem.offsetParent === null) { | ||
console.log(elem, elem.parentNode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should perhaps have been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups indeed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52517.
r? @nrc