Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #53206

Closed
wants to merge 25 commits into from
Closed

Rollup of 12 pull requests #53206

wants to merge 25 commits into from

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Aug 8, 2018

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 25 commits August 5, 2018 19:44

Verified

This commit was signed with the committer’s verified signature.
davidtwco David Wood
This is a temporary workaround for Fuchsia's libc not supporting
TLS segments with alignments greater than 32 bytes. It should
be reverted ASAP following the fix to libc.
When missing a comma in a macro call, suggest it, regardless of
position. When a macro call doesn't match any of the patterns, check
if the call's token stream could be missing a comma between two idents,
and if so, create a new token stream containing the comma and try to
match against the macro patterns. If successful, emit the suggestion.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…omatsakis

Avoid unnecessary pattern matching against Option and Result

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…=Mark-Simulacrum

Move SmallVector and ThinVec out of libsyntax

- move `libsyntax::util::SmallVector` tests to `librustc_data_structures::small_vec`
- remove `libsyntax::util::SmallVector`
- move `libsyntax::util::thin_vec` to `librustc_data_structures::thin_vec`

Other than moving these data structures where they belong it allows modules using `SmallVector<T>` (`SmallVec<[T; 1]>`) to specify their own length (e.g. 8 or 32) independently from `libsyntax`.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Automatically expand section if url id point to one of its component

Fixes rust-lang#52517.

r? @nrc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…s, r=eddyb

Fix improper_ctypes lint for individual foreign items

Fixes rust-lang#52456.

r? @eddyb

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…=nrc

Account for --remap-path-prefix in save-analysis

Fixes rust-lang#52549.

Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format?

Session is already created with remapped working directory, so use that instead of the actual cwd.
This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones.

r? @nrc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…excrichton

NetBSD: fix signedess of char

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…static, r=nikomatsakis

NLL says something "does not live long enough" when talking about a (thread-local) static

Part of rust-lang#52663.

r? @nikomatsakis

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…tion-debuginfo-test, r=kennytm

Re-enable drop-locations debuginfo tests.

The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Avoid increased alignment of TLS segments on Fuchsia

This is a temporary workaround for Fuchsia's libc not supporting
TLS segments with alignments greater than 32 bytes. It should
be reverted ASAP following the fix to libc.

cc @petrhosek

r? @alexcrichton

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Suggest comma when missing in macro call

When missing a comma in a macro call, suggest it, regardless of
position. When a macro call doesn't match any of the patterns, check
if the call's token stream could be missing a comma between two idents,
and if so, create a new token stream containing the comma and try to
match against the macro patterns. If successful, emit the suggestion.

This works on arbitrary macros, with no need of special support from
the macro writers.

```
error: no rules expected the token `d`
  --> $DIR/missing-comma.rs:26:18
   |
LL |     foo!(a, b, c d, e);
   |                 -^
   |                 |
   |                 help: missing comma here
```
Follow up to rust-lang#52397.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes rust-lang#53119.

Fixes rust-lang#53119.

I minimized sample little bit more, but I checked the sample from issue too.
r? @nikomatsakis
@cramertj
Copy link
Member Author

cramertj commented Aug 8, 2018

@bors r+ p=13

@bors
Copy link
Contributor

bors commented Aug 8, 2018

📌 Commit 888c158 has been approved by cramertj

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 8, 2018
@bors
Copy link
Contributor

bors commented Aug 8, 2018

⌛ Testing commit 888c158 with merge c06e6a0c1e3db2ebf56d8a7985537b913b0b39ec...

@bors
Copy link
Contributor

bors commented Aug 8, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2018
@cramertj cramertj closed this Aug 8, 2018
@cramertj cramertj deleted the rollup branch August 8, 2018 23:57
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nll] gluon_base does not compile with NLL