tidy: Stop requiring a license header #53617
Conversation
Previously approved in rust-lang#43498 ; update tidy to match.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Do we want to eventually clean these out from all the files? It'd potentially be a nice win for disk space especially for tests and the like. |
|
cc @rust-lang/compiler @rust-lang/core for awareness @bors r+ |
|
📌 Commit a15b617 has been approved by |
bors
added
S-waiting-on-bors
|
@Mark-Simulacrum Eventually, yes. But that has the same potential pitfalls as systematically running rustfmt. :) (Disk space isn't a very good reason to do it, but ease of code navigation and reading is.) |
|
Agreed that disk space isn't a good reason, but I'm not sure I agree the pitfalls are all that bad. In theory, at least, I would expect this to have essentially 0 conflicts since no one is changing those lines, unlike rustfmt. Maybe I don't understand how git works though :) |
|
I don't think git should complain much here. I don't mind starting on this if there are no objections. |
…, r=Mark-Simulacrum tidy: Stop requiring a license header Previously approved in rust-lang#43498 ; update tidy to match.
|
@Mark-Simulacrum The main annoyance would be that such a change would touch almost every file, making logs and browsing just that little bit more annoying. But it wouldn't be that bad, true. |
|
@joshtriplett I submitted #53654. If that looks like a reasonable way to proceed, then I can do more. Let me know. |
|
Hmm... @bors doesn't appear to be testing anything ATM... |
…, r=Mark-Simulacrum tidy: Stop requiring a license header Previously approved in rust-lang#43498 ; update tidy to match.
Rollup of 16 pull requests Successful merges: - #53311 (Window Mutex: Document that we properly initialize the SRWLock) - #53503 (Discourage overuse of mem::forget) - #53545 (Fix #50865: ICE on impl-trait returning functions reaching private items) - #53559 (add macro check for lint) - #53562 (Lament the invincibility of the Turbofish) - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into()) - #53592 (docs: minor stylistic changes to str/string docs) - #53594 (Update RELEASES.md to include clippy-preview) - #53600 (Fix a grammatical mistake in "expected generic arguments" errors) - #53614 (update nomicon and book) - #53617 (tidy: Stop requiring a license header) - #53618 (Add missing fmt examples) - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.) - #53644 (Use SmallVec for SmallCStr) - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs) - #53666 (Added rustc_codegen_llvm to compiler documentation.)
The tidy check was removed in rust-lang#53617
Remove unused ignore-license directives The tidy check was removed in rust-lang#53617
Previously approved in #43498 ; update tidy to match.