Add missing fmt examples #53618
Merged
Add missing fmt examples #53618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/libcore/fmt/mod.rs
Outdated
| /// impl fmt::Display for Foo { | ||
| /// fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result { | ||
| /// // We need to remove "-" from the number output. | ||
| /// let tmp = if self.nb < 0 { self.nb * -1 } else { self.nb }.to_string(); |
There was a problem hiding this comment.
This could probably be expressed as self.nb.abs().to_string().
There was a problem hiding this comment.
This would be better actually.
GuillaumeGomez
force-pushed
the
fmt-examples
branch
from
46e456a to
2cc2e01
Compare
|
Updated. |
|
@bors r+ (travis is actually green if you click through, github never updated with the result) |
|
📌 Commit 2cc2e01 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 24, 2018
…tMisdreavus Add missing fmt examples r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Aug 24, 2018
Rollup of 16 pull requests Successful merges: - #53311 (Window Mutex: Document that we properly initialize the SRWLock) - #53503 (Discourage overuse of mem::forget) - #53545 (Fix #50865: ICE on impl-trait returning functions reaching private items) - #53559 (add macro check for lint) - #53562 (Lament the invincibility of the Turbofish) - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into()) - #53592 (docs: minor stylistic changes to str/string docs) - #53594 (Update RELEASES.md to include clippy-preview) - #53600 (Fix a grammatical mistake in "expected generic arguments" errors) - #53614 (update nomicon and book) - #53617 (tidy: Stop requiring a license header) - #53618 (Add missing fmt examples) - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.) - #53644 (Use SmallVec for SmallCStr) - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs) - #53666 (Added rustc_codegen_llvm to compiler documentation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @QuietMisdreavus