Updated 1.29 release notes with --document-private-items flag #54150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Marking this as stable-nominated/accepted to make sure we include it if we make a point release. |
pietroalbini
added
stable-nominated
|
Hm, is this really a cargo feature? It sort of feels like it should be in a rustdoc section... but it probably doesn't matter too much. @bors r+ rollup |
|
📌 Commit 3c1efcd has been approved by |
bors
added
S-waiting-on-bors
|
@Mark-Simulacrum Yeah, it is a cargo feature-- rustdoc has been able to do this for a while, but this is the first time it has been exposed through cargo. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Sep 13, 2018
Updated 1.29 release notes with --document-private-items flag [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md#cargo)
bors
added a commit
that referenced
this pull request
Sep 13, 2018
Rollup of 11 pull requests Successful merges: - #53371 (Do not emit E0277 on incorrect tuple destructured binding) - #53829 (Add rustc SHA to released DWARF debuginfo) - #53950 (Allow for opting out of ThinLTO and clean up LTO related cli flag handling.) - #53976 (Replace unwrap calls in example by expect) - #54070 (Add Error::description soft-deprecation to RELEASES) - #54076 (miri loop detector hashing) - #54119 (Add some unit tests for find_best_match_for_name) - #54147 (Add a test that tries to modify static memory at compile-time) - #54150 (Updated 1.29 release notes with --document-private-items flag) - #54163 (Update stage 0 to latest beta) - #54170 (COMPILER_TESTS.md has been moved)
bors
added a commit
that referenced
this pull request
Oct 5, 2018
1.29.2 stable point release This point release includes a backport of #54639 (a miscompilation) and the fix for #54206 (rls missing on windows-gnu). It also backports a release notes fix (#54150). The target date for the release is Thursday 11th. r? @Mark-Simulacrum cc @rust-lang/core @rust-lang/release
pietroalbini
removed
the
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered