1.29.2 stable point release #54808
1.29.2 stable point release #54808
Conversation
This will be re-enabled sooner or later depending on results of further investigation. Fixes rust-lang#54462
|
rust-highfive
added
the
S-waiting-on-review
RELEASES.md
Outdated
| Version 1.29.2 (2018-10-11) | ||
| =========================== | ||
|
|
||
| Compatibility Notes |
There was a problem hiding this comment.
Is this the right category for these fixes? They don't look like they break backwards compatibility.
There was a problem hiding this comment.
Other point releases did put all of the fixes in the compatibility notes. I just removed the section name.
RELEASES.md
Outdated
| Compatibility Notes | ||
| ------------------- | ||
|
|
||
| - [Fixed unsoundness in the aliasing rules, which caused miscompilation.][54639] |
There was a problem hiding this comment.
I'd suggest something like "Work around aliasing-related LLVM bug, which caused miscompilations" here. The current description sounds to me like there was some kind of unsoundness in Rust's aliasing rules.
pietroalbini
force-pushed
the
stable-1.29.2
branch
from
9689193 to
a154257
Compare
|
This all looks good to me, I'd like to run the RLS fixing change by @alexcrichton to make sure this is exactly what you wanted (since you had some concerns earlier, I believe). So, r? @alexcrichton for final approval |
|
@bors: r+ p=100 |
|
📌 Commit a154257 has been approved by |
bors
added
S-waiting-on-bors
|
I think this is the right fix, but I'll confirm with the actual artifacts once they exist. |
1.29.2 stable point release This point release includes a backport of #54639 (a miscompilation) and the fix for #54206 (rls missing on windows-gnu). It also backports a release notes fix (#54150). The target date for the release is Thursday 11th. r? @Mark-Simulacrum cc @rust-lang/core @rust-lang/release
|
☀️ Test successful - status-appveyor, status-travis |
|
Cargo seems functional in 1.29.2 and the RLS was built for x86_64-pc-windows-gnu, should be good to go! |
This point release includes a backport of #54639 (a miscompilation) and the fix for #54206 (rls missing on windows-gnu). It also backports a release notes fix (#54150).
The target date for the release is Thursday 11th.
r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release