Rollup of 10 pull requests #54432
Closed
Rollup of 10 pull requests #54432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let cargo handle that for us Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
This is a safe wrapper around ptr::copy, for regions within a single slice. Previously, safe in-place copying was only available as a side effect of Vec::drain.
The no_default_libraries was introduced in rust-lang#28578 because the NetBSD-based rumprun needed to disable the link flag. This moves the definition to be used by all NetBSD linker flavors to close rust-lang#49627. A different solution would be adding -lc but as there is no platform with explicit -lc, this approach is used.
…chton define copy_within on slices This is a safe wrapper around `ptr::copy`, for regions within a single slice. Previously, safe in-place copying was only available as a side effect of `Vec::drain`. I've wanted this API a couple times in the past, and I figured I'd just whip up a PR to help discuss it. It's possible something like this exists elsewhere and I just missed it. It might also be a big enough addition to warrant an RFC, I'm not sure.
…nkov Make `dyn` a keyword in the 2018 edition Proposed in rust-lang#44662 (comment).
…apin Implement the dbg!(..) macro Implements the `dbg!(..)` macro due to rust-lang#54306. cc rust-lang/rfcs#2361 r? @alexcrichton
rustbuild: drop color handling Let cargo handle that for us Fixes rust-lang#54322 Needs a beta backport
… r=GuillaumeGomez add -Zui-testing to rustdoc Before we depend on the `rustdoc-ui` tests some more, let's make rustdoc act the same as the compiler when they're actually being executed.
…crichton Make 'proc_macro::MultiSpan' public. Oversight from rust-lang#52896.
Use no_default_libraries for all NetBSD flavors The no_default_libraries was introduced in rust-lang#28578 because the NetBSD-based rumprun needed to disable the link flag. This moves the definition to be used by all NetBSD linker flavors to close rust-lang#49627. A different solution would be adding -lc but as there is no platform with explicit -lc, this approach is used.
…tebank add applicability to span_suggestion call Found another `span_suggestion` call. Issue rust-lang#50723 r? @estebank
…tebank Add UI test for deref recursion limit printing twice Closes rust-lang#38940 Does ``NOTE`` in the test need to be changed to ``HELP`` if its in the stderr? ``help: consider adding a `#![recursion_limit="20"]` attribute to your crate`` It doesn't appear to complaining locally that the line isn't set to ``HELP`` in the test, and the guide says > HELP and SUGGESTION* > * Note: SUGGESTION must follow immediately after HELP. yet there's no concrete suggestion emitted. r? @estebank
…Simulacrum Simplify slice's first(_mut) and last(_mut) with get This change makes these functions easier to read and interpret. I haven't detected any difference in performance locally. r? @Mark-Simulacrum
|
@bors r+ p=10 |
|
📌 Commit e6b2e80 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 21, 2018
Rollup of 10 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54317 (Implement the dbg!(..) macro) - #54323 (rustbuild: drop color handling) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54422 (Simplify slice's first(_mut) and last(_mut) with get)
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
dyna keyword in the 2018 edition #54261 (Makedyna keyword in the 2018 edition)