Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize impl_header_lifetime_elision in 2015 #54778

Merged
merged 6 commits into from
Oct 23, 2018

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Oct 3, 2018

This is currently blocked on #54902; it should be good after that

It's already stable in 2018; this finishes the stabilization.

FCP completed (#15872 (comment)), proposal (#15872 (comment)).

Tracking issue: #15872
Usage examples (from libcore): #54687

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2018
@scottmcm scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2018
@rust-highfive

This comment has been minimized.

@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 6, 2018
@bors
Copy link
Contributor

bors commented Oct 7, 2018

☔ The latest upstream changes (presumably #54835) made this pull request unmergeable. Please resolve the merge conflicts.

@scottmcm
Copy link
Member Author

scottmcm commented Oct 8, 2018

Well, this found a bug in the feature 🙂

This is currently blocked by #54902

@scottmcm
Copy link
Member Author

scottmcm commented Oct 8, 2018

Fixing the test failures, it looks like this stabilization will finally make this issue from 2014 work 🙂

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@scottmcm scottmcm force-pushed the stabilize-ihle branch 3 times, most recently from 2308ac4 to c0ede9d Compare October 9, 2018 07:37
@rust-highfive

This comment has been minimized.

@rust-lang rust-lang deleted a comment from rust-highfive Oct 9, 2018
@rust-lang rust-lang deleted a comment from rust-highfive Oct 9, 2018
@bors
Copy link
Contributor

bors commented Oct 11, 2018

☔ The latest upstream changes (presumably #54969) made this pull request unmergeable. Please resolve the merge conflicts.

@scottmcm scottmcm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Oct 14, 2018
@scottmcm scottmcm changed the title [WIP] Stabilize impl_header_lifetime_elision in 2015 [Blocked] Stabilize impl_header_lifetime_elision in 2015 Oct 14, 2018
@scottmcm scottmcm removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 14, 2018
@rust-highfive

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Oct 18, 2018

☔ The latest upstream changes (presumably #55134) made this pull request unmergeable. Please resolve the merge conflicts.

But its test was written in an outdated way that hits a different error despite IHLE, so keep a variant around for that case.
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 20, 2018
@scottmcm scottmcm changed the title [Blocked] Stabilize impl_header_lifetime_elision in 2015 Stabilize impl_header_lifetime_elision in 2015 Oct 20, 2018
@scottmcm
Copy link
Member Author

Ok, looks like this is finally ready for a review, @pnkfelix. Let me know if there's anything else I should change, or if you'd prefer that I squash some of the commits.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 22, 2018

📌 Commit 18f7db3 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2018
@bors
Copy link
Contributor

bors commented Oct 23, 2018

⌛ Testing commit 18f7db3 with merge d570b36...

bors added a commit that referenced this pull request Oct 23, 2018
Stabilize impl_header_lifetime_elision in 2015

~~This is currently blocked on #54902; it should be good after that~~

It's already stable in 2018; this finishes the stabilization.

FCP completed (#15872 (comment)), proposal (#15872 (comment)).

Tracking issue: #15872
Usage examples (from libcore): #54687
@bors
Copy link
Contributor

bors commented Oct 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing d570b36 to master...

@bors bors merged commit 18f7db3 into rust-lang:master Oct 23, 2018
@scottmcm scottmcm deleted the stabilize-ihle branch October 23, 2018 06:59
scottmcm added a commit to scottmcm/edition-guide that referenced this pull request Oct 23, 2018
@Centril Centril added this to the 1.31 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants