-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #54969
Rollup of 9 pull requests #54969
Conversation
Does not implement the warning or a feature flag.
This commit enhances `LaterUseKind` detection to identify when a borrow is captured by a trait object which helps explain why there is a borrow error.
This commit updates the captured trait object search logic to look for unsized casts to boxed types rather than for functions that returned trait objects.
* Rule ProjectionEq-Skolemize * Rule WellFormed-AssocTy * Rule Implied-Trait-From-AssocTy
@bors r+ p=100 |
📌 Commit 5bc2cca1a0028f8fbd284b1b4102d9f84e4a1d57 has been approved by |
⌛ Testing commit 5bc2cca1a0028f8fbd284b1b4102d9f84e4a1d57 with merge facfab42cd578fc94c1a362dcf9a24dc5db48328... |
💔 Test failed - status-appveyor |
📌 Commit be64bf3 has been approved by |
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
☀️ Test successful - status-appveyor, status-travis |
📣 Toolstate changed by #54969! Tested on commit cb6eedd. 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
Tested on commit rust-lang/rust@cb6eedd. Direct link to PR: <rust-lang/rust#54969> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
@Manishearth It looks like there is something strange happening in this kind of rollup merges. This rollup consists of multiple merge commits. All this merge commits seem to have the same commit message body unrelated to the actual thing being merged:
This usage of the same commit message body seems to go back to Feb 2018 as it can be seen in #47311. Do you have some idea what is going on here? |
Oh, shoot. Yeah, I used a script since it's easier to handle, looks like something on the github side changed . Thanks for noticing, will fix up my script! |
Successful merges:
;
or{
, found{ ... }
#54707 - parse_trait_item_ now handles interpolated blocks as function body decls)Option::replace
method #54904 (Stabilize theOption::replace
method)Failed merges:
r? @ghost