Allow extern statics with an extern type #55257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry if I've spammed this thread with comments or resolving nits. The recent GitHub outage is still ongoing and is causing this pull request to have an inconsistent state every time I reload the page, and so I might have duplicated some comments or button pushes. Apologies for the spam. |
oli-obk
approved these changes
Oct 22, 2018
|
@bors r+ |
|
📌 Commit 5b84550 has been approved by |
bors
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 24, 2018
Allow extern statics with an extern type Fixes rust-lang#55239
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 25, 2018
Allow extern statics with an extern type Fixes rust-lang#55239
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 27, 2018
Allow extern statics with an extern type Fixes rust-lang#55239
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 28, 2018
Allow extern statics with an extern type Fixes rust-lang#55239
bors
added a commit
that referenced
this pull request
Oct 28, 2018
Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)
This was referenced Feb 5, 2019
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 7, 2019
Do not ICE in codegen when using a extern_type static The layout of a extern_type static is unsized, but may pass the Well-Formed check in typeck (See rust-lang#55257). As a result, we cannot assume that a static is sized when generating the `Place` for an r-value. Fixes: rust-lang#57876 r? @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55239