Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary mut in iterator.find_map documentation example, R… #55389

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Remove unnecessary mut in iterator.find_map documentation example, R… #55389

merged 1 commit into from
Oct 28, 2018

Conversation

meven
Copy link
Contributor

@meven meven commented Oct 26, 2018 •
edited
Loading

Relates to #49098

Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about.

https://github.com/rust-lang/rust/pull/49098/files#r227422388

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2018
@meven meven mentioned this pull request Oct 26, 2018
Merged
@meven meven changed the title Remove unnecessary mut in iterartor.find_map documentation example, R… Remove unnecessary mut in iterator.find_map documentation example, R… Oct 26, 2018
@meven
Copy link
Contributor Author

meven commented Oct 26, 2018 •
edited
Loading

I left a typo in the commit message, perhaps it would be best to remake a new one with that fixed.

@shepmaster
Copy link
Member

r? @shepmaster

@shepmaster
Copy link
Member

to remake a new one with that fixed.

You can amend the commit message locally and then force-push the branch:

git commit --amend
# editor opens
git push the-name-of-your-remote +the-name-of-your-branch

@shepmaster
Copy link
Member

amend [...] force-push

And if you don't feel comfortable with that, I believe I can do it for you.

@meven
Copy link
Contributor Author

meven commented Oct 26, 2018

Fixed, I did not know I could use amend without impacting the PR.
Thanks for the tip.

@shepmaster
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2018

📌 Commit c674802 has been approved by shepmaster

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2018
@shepmaster
Copy link
Member

Thanks!

@meven
Copy link
Contributor Author

meven commented Oct 27, 2018

Happy to contribute :-)

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#55389 - meven:master, r=shepmaster
18d3f3f 
Remove unnecessary mut in iterator.find_map documentation example, R…

Relates to rust-lang#49098

Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about.

https://github.com/rust-lang/rust/pull/49098/files#r227422388
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 27, 2018
Closed
@kennytm kennytm mentioned this pull request Oct 28, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018
@kennytm
Rollup merge of rust-lang#55389 - meven:master, r=shepmaster
316a443 
Remove unnecessary mut in iterator.find_map documentation example, R…

Relates to rust-lang#49098

Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about.

https://github.com/rust-lang/rust/pull/49098/files#r227422388
bors added a commit that referenced this pull request Oct 28, 2018
@bors
Auto merge of #55433 - kennytm:rollup, r=kennytm
d492c67 
Rollup of 11 pull requests

Successful merges:

 - #55148 (Implement FromStr for PathBuf)
 - #55185 (path suggestions in Rust 2018 should point out the change in semantics)
 - #55191 (Fix sub-variant doc display)
 - #55199 (Impl items have generics)
 - #55244 (Don't rerun MIR passes when inlining)
 - #55252 (Add MaybeUninit::new)
 - #55257 (Allow extern statics with an extern type)
 - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
 - #55406 (Update string.rs)
 - #55412 (Fix an ICE in the min_const_fn analysis)
 - #55421 (Add ManuallyDrop::take)
@bors bors merged commit c674802 into rust-lang:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shepmaster shepmaster

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meven @rust-highfive @shepmaster @bors @withoutboats