Update an outdated comment in mir building #56127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Nov 21, 2018
| // In constants, temp_lifetime is None. We should not need to drop | ||
| // anything because no values with a destructor can be created in | ||
| // a constant at this time, even if the type may need dropping. | ||
| // In constants, temp_lifetime is None. We do not drop anything because |
There was a problem hiding this comment.
It's not None except for the outermost scope. We need to keep all other drops in, to get errors about them (since they will execute in the future).
eddyb
reviewed
Nov 21, 2018
| // In constants, temp_lifetime is None. We do not drop anything because | ||
| // values with a destructor will simply be leaked in constants. | ||
| // In constants, temp_lifetime is None for temporaries that live for the | ||
| // entire constant. Thus we do not drop these temporaries and simply leak them. |
There was a problem hiding this comment.
Not "entire constant". The semantics of shallow temporaries in the RHS of a binding is that they escape into the ambient scope. For a const/static, this ambient scope is 'static.
eddyb
approved these changes
Nov 21, 2018
|
r? @nikomatsakis (just in case) |
nikomatsakis
approved these changes
Nov 26, 2018
|
@bors r+ rollup |
|
📌 Commit 925274a has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 27, 2018
…tsakis Update an outdated comment in mir building r? @eddyb
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 28, 2018
…tsakis Update an outdated comment in mir building r? @eddyb
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 29, 2018
…tsakis Update an outdated comment in mir building r? @eddyb
bors
added a commit
that referenced
this pull request
Nov 29, 2018
Rollup of 22 pull requests Successful merges: - #55391 (bootstrap: clean up a few clippy findings) - #56021 (avoid features_untracked) - #56023 (atomic::Ordering: Get rid of misleading parts of intro) - #56080 (Reduce the amount of bold text at doc.rlo) - #56114 (Enclose type in backticks for "non-exhaustive patterns" error) - #56124 (Fix small doc mistake on std::io::read::read_to_end) - #56127 (Update an outdated comment in mir building) - #56148 (Add rustc-guide as a submodule) - #56149 (Make std::os::unix/linux::fs::MetadataExt::a/m/ctime* documentation clearer) - #56220 (Suggest appropriate place for lifetime when declared after type arguments) - #56223 (Make JSON output from -Zprofile-json valid) - #56236 (Remove unsafe `unsafe` inner function.) - #56255 (Update outdated code comments in StringReader) - #56257 (rustc-guide has moved to rust-lang/) - #56273 (Add missing doc link) - #56289 (Fix small typo in comment of thread::stack_size) - #56294 (Fix a typo in the documentation of std::ffi) - #56312 (Deduplicate literal -> constant lowering) - #56319 (fix futures creating aliasing mutable and shared ref) - #56321 (rustdoc: add bottom margin spacing to nested lists) - #56322 (resolve: Fix false-positives from lint `absolute_paths_not_starting_with_crate`) - #56330 (Clean up span in non-trailing `..` suggestion) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb