Fix moving text in search tabs headers #59026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
ping from triage @QuietMisdreavus waiting for your review on this |
|
Where is this issue occurring? What problem is this fixing? |
Dylan-DPC-zz
added
S-waiting-on-author
|
I can't make a screenshot for it so you'll have to test it yourself: once you have search results (or not results, it doesn't matter), just switch between tabs and look at the tabs' headers' text when siwtch (doing it with tab is more obvious). In current rendering, the text moves a bit, this PR fixes this move. |
|
Ah, now i see it. Thanks for the explanation! @bors r+ rollup |
|
📌 Commit 6a4cced has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 26, 2019
…r=QuietMisdreavus Fix moving text in search tabs headers Fixes rust-lang#59005. Now, the text in the search tabs headers isn't moving anymore. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Mar 26, 2019
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Mar 27, 2019
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59005.
Now, the text in the search tabs headers isn't moving anymore.
r? @QuietMisdreavus