-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #59447
Rollup of 7 pull requests #59447
Conversation
This adds some missing documentation for rustfix related things and adds a test for the `is_test` function.
…=QuietMisdreavus [rustdoc] Improve "in parameters" search and search more generally Fixes rust-lang#58230. r? @QuietMisdreavus
…r=QuietMisdreavus Fix moving text in search tabs headers Fixes rust-lang#59005. Now, the text in the search tabs headers isn't moving anymore. r? @QuietMisdreavus
Exclude old book redirect stubs from search engines Adds `<meta name="robots" content="noindex,follow">` to the `<head>` of old stub pages pointing to the second edition of the book. This is continuation of rust-lang/book#1788
…ation, r=steveklabnik Improve the documentation for std::convert (From, Into, AsRef and AsMut) # Description In this PR I updated the documentation of From, Into, AsRef and AsMut, as well as the general std::convert module documentation. The discussion in rust-lang#59163 provided information that was not yet present in the docs, or was not expressed clearly enough. I tried to clarify the examples that were already present in the docs as well as add more information about considered best-practices that came out of the discussion in rust-lang#59163 @steveklabnik I hope I didn't change too much. This is an initial version! I will scan through everything tomorrow as well again to see if I made any typo's or errors, and maybe make some small changes here and there. All suggestions are welcome! closes rust-lang#59163
…=QuietMisdreavus Fix code block display in portability element in dark theme Fixes rust-lang#59261. r? @QuietMisdreavus A little screenshot: <img width="521" alt="Screenshot 2019-03-26 at 00 37 49" src="https://user-images.githubusercontent.com/3050060/54961082-9a41c600-4f5f-11e9-8040-ae6f26d368ff.png">
…-Simulacrum Link to PhantomData in NonNull documentation
…chton Improve some compiletest documentation This adds some missing documentation for rustfix related things and adds a test for the `is_test` function.
@bors: r+ p=7 |
📌 Commit cbb13f4 has been approved by |
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
☀️ Test successful - checks-travis, status-appveyor |
Successful merges:
Failed merges:
r? @ghost