Use "capacity" as parameter name in with_capacity() methods

[mgeier]

See #60271.

The only place where I didn't change the parameter name is RawVec. The problem is that it has a .cap() method instead of the usual .capacity():

rust/src/liballoc/raw_vec.rs

Lines 200 to 210 in 597f432

	/// Gets the capacity of the allocation.
	///
	/// This will always be `usize::MAX` if `T` is zero-sized.
	#[inline(always)]
	pub fn cap(&self) -> usize {
	if mem::size_of::<T>() == 0 {
	!0
	} else {
	self.cap
	}
	}

Changing this would be a breaking change, and I guess that's not worth it.

But since I didn't change .cap() there, I didn't change the cap parameter name to capacity, either.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[mgeier]

I've found two more evil .cap() methods:

rust/src/libstd/sync/mpsc/sync.rs

Lines 461 to 479 in 597f432

	impl<T> Buffer<T> {
	fn enqueue(&mut self, t: T) {
	let pos = (self.start + self.size) % self.buf.len();
	self.size += 1;
	let prev = mem::replace(&mut self.buf[pos], Some(t));
	assert!(prev.is_none());
	}
	fn dequeue(&mut self) -> T {
	let start = self.start;
	self.size -= 1;
	self.start = (self.start + 1) % self.buf.len();
	let result = &mut self.buf[start];
	result.take().unwrap()
	}
	fn size(&self) -> usize { self.size }
	fn cap(&self) -> usize { self.buf.len() }
	}

rust/src/liballoc/collections/vec_deque.rs

Lines 87 to 103 in 597f432

	impl<T> VecDeque<T> {
	/// Marginally more convenient
	#[inline]
	fn ptr(&self) -> *mut T {
	self.buf.ptr()
	}
	/// Marginally more convenient
	#[inline]
	fn cap(&self) -> usize {
	if mem::size_of::<T>() == 0 {
	// For zero sized types, we are always at maximum capacity
	MAXIMUM_ZST_CAPACITY
	} else {
	self.buf.cap()
	}
	}

[joshtriplett]

@bors r+

[bors]

📌 Commit be12ab0 has been approved by joshtriplett

[estebank]

@bors rollup

[bors]

☔ The latest upstream changes (presumably #60329) made this pull request unmergeable. Please resolve the merge conflicts.