upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802

euclio · 2019-05-13T21:22:13Z

rust-highfive · 2019-05-13T23:09:11Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0128d6de:start=1557782604023451807,finish=1557782604857405369,duration=833953562
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:23:23] 
[01:23:23] running 143 tests
[01:23:26] i..iii.....iii...iiii....i......................i..i.................i.....i..........ii.i..i..i.ii. 100/143
[01:23:28] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:23:28] 
[01:23:28]  finished in 4.553
[01:23:28] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:23:30] 
[01:23:30] running 9 tests
[01:23:30] iiiiiiiii
[01:23:30] 
[01:23:30]  finished in 0.152
[01:23:30] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:23:45] 
[01:23:45] running 122 tests
[01:24:10] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:24:15] .i.i......iii.i.....ii
[01:24:15] 
[01:24:15]  finished in 29.532
[01:24:15] travis_fold:end:test_debuginfo

---
[01:45:30]     Finished release [optimized] target(s) in 1m 03s
[01:45:30]      Running build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/rustdoc-673b6a025d1a02b5
[01:45:30] 
[01:45:30] running 42 tests
[01:45:30] ............F.............................
[01:45:30] 
[01:45:30] ---- html::markdown::tests::test_header stdout ----
[01:45:30] thread 'html::markdown::tests::test_header' panicked at 'assertion failed: `(left == right)`
[01:45:30] thread 'html::markdown::tests::test_header' panicked at 'assertion failed: `(left == right)`
[01:45:30]   left: `"<h4 id=\"foo--bar----qux\" class=\"section-header\"><a href=\"#foo--bar----qux\"><strong>Foo?</strong> &amp; *bar?!*  <em><code>baz</code></em> ❤ #qux</a></h4>"`,
[01:45:30]  right: `"<h4 id=\"foo--bar--baz--qux\" class=\"section-header\"><a href=\"#foo--bar--baz--qux\"><strong>Foo?</strong> &amp; *bar?!*  <em><code>baz</code></em> ❤ #qux</a></h4>"`: original: #### **Foo?** & \*bar?!*  _`baz`_ ❤ #qux', src/librustdoc/html/markdown.rs:1100:13
[01:45:30] 
[01:45:30] 
[01:45:30] failures:
[01:45:30]     html::markdown::tests::test_header
[01:45:30]     html::markdown::tests::test_header
[01:45:30] 
[01:45:30] test result: FAILED. 41 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:45:30] 
[01:45:30] error: test failed, to rerun pass '--lib'
[01:45:30] 
[01:45:30] 
[01:45:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml" "-p" "rustdoc:0.0.0" "--" "--quiet"
[01:45:30] 
[01:45:30] 
[01:45:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:45:30] Build completed unsuccessfully in 0:33:51
[01:45:30] Build completed unsuccessfully in 0:33:51
[01:45:30] make: *** [check] Error 1
[01:45:30] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0890cc6c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon May 13 23:09:04 UTC 2019
---
travis_time:end:0cd9132a:start=1557788946786115900,finish=1557788946790922809,duration=4806909
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b7f74aa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09e63e20
travis_time:start:09e63e20
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:018e5630
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-05-14T14:00:31Z

r? @QuietMisdreavus

euclio · 2019-05-14T14:28:22Z

src/librustdoc/html/markdown.rs

                Event::Start(Tag::Header(_)) => (None, 1),
+                Event::Code(code) => (Some(format!("`{}`", code)), 0),


~~This might need a self.is_in check like the Event::Text arm.~~

It doesn't, since you can't create an inline code block outside of a paragraph or header.

euclio · 2019-05-26T21:15:52Z

We may want to hold off on this until pulldown-cmark/pulldown-cmark#325 is merged and released.

marcusklaas · 2019-05-27T22:11:32Z

The pull request has been merged and we're now preparing a bug fixing release (0.5.2). Shouldn't be more than a day or two.

marcusklaas · 2019-05-28T21:14:31Z

0.5.2 has been released!

GuillaumeGomez · 2019-05-29T08:52:16Z

@euclio You can update I guess? ;)

Fixes rust-lang#60482.

euclio · 2019-05-29T17:40:35Z

@GuillaumeGomez Updated.

GuillaumeGomez · 2019-05-29T18:15:34Z

Thanks!

@bors: r+

bors · 2019-05-29T18:15:35Z

📌 Commit ed8a4d5 has been approved by GuillaumeGomez

…laumeGomez upgrade rustdoc's `pulldown-cmark` to 0.5.2 Fixes rust-lang#60482.

@ghost

Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost

@ghost

Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost

jonas-schievink · 2019-06-02T17:12:27Z

This also affects beta (and shows up a lot in the crater runs in #61401), nominating for backport

QuietMisdreavus · 2019-06-05T20:59:49Z

Accepting backport nomination.

@ghost

[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost

@ghost

[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost

rust-highfive assigned alexcrichton May 13, 2019

euclio force-pushed the pulldown-cmark-panic branch from 5f24ee5 to 532c2cc Compare May 13, 2019 23:46

rust-highfive assigned QuietMisdreavus and unassigned alexcrichton May 14, 2019

euclio commented May 14, 2019

View reviewed changes

euclio force-pushed the pulldown-cmark-panic branch from 532c2cc to f28280b Compare May 29, 2019 14:58

euclio changed the title ~~upgrade rustdoc's pulldown-cmark to 0.5.1~~ upgrade rustdoc's pulldown-cmark to 0.5.2 May 29, 2019

upgrade rustdoc's pulldown-cmark to 0.5.2

ed8a4d5

Fixes rust-lang#60482.

euclio force-pushed the pulldown-cmark-panic branch from f28280b to ed8a4d5 Compare May 29, 2019 15:00

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 29, 2019

Centril added a commit to Centril/rust that referenced this pull request May 30, 2019

Rollup merge of rust-lang#60802 - euclio:pulldown-cmark-panic, r=Guil…

040af62

…laumeGomez upgrade rustdoc's `pulldown-cmark` to 0.5.2 Fixes rust-lang#60482.

Centril mentioned this pull request May 30, 2019

Rollup of 11 pull requests #61343

Merged

bors merged commit ed8a4d5 into rust-lang:master May 30, 2019

euclio deleted the pulldown-cmark-panic branch May 31, 2019 14:53

jonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 2, 2019

This was referenced Jun 3, 2019

rustdoc ICE (1/3) in markdown - index out of bounds #61477

Closed

rustdoc ICE (2/3) in markdown - unexpected node in tree (Header) #61478

Closed

Mark-Simulacrum mentioned this pull request Jun 3, 2019

rustdoc ICE (3/3) in markdown - unwrap on nil value #61479

Closed

QuietMisdreavus added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 5, 2019

pietroalbini mentioned this pull request Jun 6, 2019

[beta] Rollup backports #61602

Merged

pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802

upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802

euclio commented May 13, 2019

rust-highfive commented May 13, 2019

alexcrichton commented May 14, 2019

euclio May 14, 2019 •

edited

Loading

euclio commented May 26, 2019 •

edited

Loading

marcusklaas commented May 27, 2019

marcusklaas commented May 28, 2019

GuillaumeGomez commented May 29, 2019

euclio commented May 29, 2019

GuillaumeGomez commented May 29, 2019

bors commented May 29, 2019

jonas-schievink commented Jun 2, 2019

QuietMisdreavus commented Jun 5, 2019

		Event::Start(Tag::Header(_)) => (None, 1),
		Event::Code(code) => (Some(format!("`{}`", code)), 0),

upgrade rustdoc's pulldown-cmark to 0.5.2 #60802

upgrade rustdoc's pulldown-cmark to 0.5.2 #60802

Conversation

euclio commented May 13, 2019

rust-highfive commented May 13, 2019

alexcrichton commented May 14, 2019

euclio May 14, 2019 • edited Loading

Choose a reason for hiding this comment

euclio commented May 26, 2019 • edited Loading

marcusklaas commented May 27, 2019

marcusklaas commented May 28, 2019

GuillaumeGomez commented May 29, 2019

euclio commented May 29, 2019

GuillaumeGomez commented May 29, 2019

bors commented May 29, 2019

jonas-schievink commented Jun 2, 2019

QuietMisdreavus commented Jun 5, 2019

upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802

upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802

euclio May 14, 2019 •

edited

Loading

euclio commented May 26, 2019 •

edited

Loading