Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn turbo 🐟 🍨 into an error #61189

Merged
merged 1 commit into from
May 26, 2019
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 25, 2019

Master branch part of #60989

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2019
@varkor
Copy link
Member

varkor commented May 25, 2019

r=me when Travis passes.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 25, 2019

@bors r=varkor

@bors
Copy link
Contributor

bors commented May 25, 2019

📌 Commit a15df94 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2019
Centril added a commit to Centril/rust that referenced this pull request May 26, 2019
Turn turbo 🐟 🍨 into an error

Master branch part of rust-lang#60989

r? @varkor
bors added a commit that referenced this pull request May 26, 2019
Rollup of 9 pull requests

Successful merges:

 - #61087 (Tweak `self` arg not as first argument of a method diagnostic)
 - #61114 (Vec: avoid creating slices to the elements)
 - #61144 (Suggest borrowing for loop head on move error)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)
 - #61184 (Add additional trace statements to the const propagator)
 - #61189 (Turn turbo 🐟 🍨 into an error)
 - #61193 (Add comment to explain why we change the layout for Projection)

Failed merges:

r? @ghost
@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 26, 2019
@bors bors merged commit a15df94 into rust-lang:master May 26, 2019
@oli-obk oli-obk added the stable-nominated Nominated for backporting to the compiler in the stable channel. label May 26, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented May 26, 2019

Nominating for stable backport. The backport already exists in #61208 (since this PR does not apply cleanly to stable)

@oli-obk oli-obk deleted the turbofish_ice branch May 26, 2019 09:04
@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 26, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Jun 6, 2019

discussed in T-compiler meeting. accepted for backport to beta and stable channels.

@pnkfelix pnkfelix added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Jun 6, 2019
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 6, 2019
bors added a commit that referenced this pull request Jun 6, 2019
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
bors added a commit that referenced this pull request Jun 7, 2019
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
@Centril
Copy link
Contributor

Centril commented Jun 11, 2019

Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted.

@Mark-Simulacrum Mark-Simulacrum removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants