-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship profiler with windows-gnu #61080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 23, 2019
@bors r+ |
📌 Commit 1a35a1c has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 24, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Rollup of 5 pull requests Successful merges: - rust-lang#60928 (Changes the type `mir::Mir` into `mir::Body`) - rust-lang#61035 (Avoid more symbol interning) - rust-lang#61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.) - rust-lang#61077 (Don't arena-allocate static symbols.) - rust-lang#61080 (Ship profiler with windows-gnu) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
bors
added a commit
that referenced
this pull request
May 26, 2019
Ship profiler with windows-gnu Fixes #49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: #59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
☀️ Test successful - checks-travis, status-appveyor |
Now on the latest Nightly:
This command works and generates a binary:
But the binary crashes immediately. |
Interesting, can you give share the code and backtrace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49409
I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: #59637.
r? @michaelwoerister
P.S.
I have tested only x86_64 build.