-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SliceConcatExt::connect defaults to calling join #61146
SliceConcatExt::connect defaults to calling join #61146
Conversation
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
r? @sfackler |
No one externally should be implementing this trait - what's the value in making this change? |
It reduces code duplication. And it won't be a breaking change. |
We also have precedence of when |
@bors r+ rollup |
📌 Commit 3dd114e has been approved by |
⌛ Testing commit 3dd114e with merge 79c337b8cde437ca1c625ba96661be100806eb1e... |
💔 Test failed - status-appveyor |
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
@bors r- |
What's wrong? |
Oh, that was a spurious failure, sorry! Had to explicitly unapprove failed PRs a few hours ago due to a bors bug, but I didn't look too closely if they were caused by spurious failures. @bors r=sfackler |
📌 Commit 3dd114e has been approved by |
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
Rollup of 9 pull requests Successful merges: - #60971 (Add DocFS layer to rustdoc) - #61146 (SliceConcatExt::connect defaults to calling join) - #61181 (Fix theme-checker failure) - #61267 (rustc-book: Update the rustc/clang compatibility table for xLTO.) - #61270 (Remove warnings about incr. comp. generating less debugging output.) - #61681 (Changed the error message to more clearly explain what is allowed) - #61984 (More NodeId pruning) - #62016 (Add test for issue-27697) - #62019 (Remove needless lifetimes) Failed merges: r? @ghost
It makes sense to default a deprecated method to the new one. Precedence example is
Error::cause
defaults to callingError::source
.