Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the error message to more clearly explain what is allowed #61681

Merged
merged 4 commits into from
Jun 22, 2019
Merged

Changed the error message to more clearly explain what is allowed #61681

merged 4 commits into from
Jun 22, 2019

Conversation

asfreitas
Copy link
Contributor

@asfreitas asfreitas commented Jun 9, 2019 •
edited
Loading

This is in regard to #61634. I changed the language to make it more clear what is allowed. Closes #61634

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@jonas-schievink
Copy link
Contributor

@asfreitas Okay, the change looks good. Some tests are now failing because the compiler output changed, check this guide for how to fix them :)

@jonas-schievink
Copy link
Contributor

Oh and also, you can edit the PR description to say "Closes #61634", then GitHub will automatically close that issue as fixed once this is merged.

@estebank

This comment has been minimized.

Sign in to view
@jonas-schievink jonas-schievink added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2019
@jonas-schievink

This comment has been minimized.

Sign in to view
@asfreitas

This comment has been minimized.

Sign in to view
@jonas-schievink

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2019

📌 Commit f4cd3c2 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2019
@Centril
Copy link
Contributor

Centril commented Jun 21, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 21, 2019
@Centril
Rollup merge of rust-lang#61681 - asfreitas:addSendTrait, r=estebank
b6867bd 
Changed the error message to more clearly explain what is allowed

This is in regard to rust-lang#61634. I changed the language to make it more clear what is allowed.
@Centril Centril mentioned this pull request Jun 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 21, 2019
@Centril
Rollup merge of rust-lang#61681 - asfreitas:addSendTrait, r=estebank
9eb88f3 
Changed the error message to more clearly explain what is allowed

This is in regard to rust-lang#61634. I changed the language to make it more clear what is allowed.
@Centril Centril mentioned this pull request Jun 21, 2019
Merged
bors added a commit that referenced this pull request Jun 22, 2019
@bors
Auto merge of #62041 - Centril:rollup-95eeyx7, r=Centril
e562b24 
Rollup of 9 pull requests

Successful merges:

 - #60971 (Add DocFS layer to rustdoc)
 - #61146 (SliceConcatExt::connect defaults to calling join)
 - #61181 (Fix theme-checker failure)
 - #61267 (rustc-book: Update the rustc/clang compatibility table for xLTO.)
 - #61270 (Remove warnings about incr. comp. generating less debugging output.)
 - #61681 (Changed the error message to more clearly explain what is allowed)
 - #61984 (More NodeId pruning)
 - #62016 (Add test for issue-27697)
 - #62019 (Remove needless lifetimes)

Failed merges:

r? @ghost
@bors bors merged commit f4cd3c2 into rust-lang:master Jun 22, 2019
@bjorn3 bjorn3 mentioned this pull request Jun 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error message for empty object types
6 participants
@asfreitas @rust-highfive @jonas-schievink @estebank @bors @Centril