Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #61343

Merged
merged 27 commits into from
May 30, 2019
Merged

Rollup of 11 pull requests #61343

merged 27 commits into from
May 30, 2019

Commits on May 15, 2019

  1. Stabilize RefCell::try_borrow_unguarded

    Servo has been using this since servo/servo#23196 to add a runtime check to some unsafe code, as discussed in PR rust-lang#59211. Stabilizing would help do more of the same in libraries that also have users on Stable.
    SimonSapin committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9fd4d48 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Configuration menu
    Copy the full SHA
    21aa149 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64edaec View commit details
    Browse the repository at this point in the history
  3. Refine the message to at least *mention* the attribute itself.

    Update pre-existing test's diagnostic output accordingly.
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    444f2ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4e60f53 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c8887ab View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    645f685 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. implicit Option-returning doctests

    This distinguishes `Option` and `Result`-returning doctests with
    implicit `main` method, where the former tests must end with
    `Some(())`.
    llogiq committed May 28, 2019
    Configuration menu
    Copy the full SHA
    6bb6c00 View commit details
    Browse the repository at this point in the history
  2. Revert "Disable solaris target since toolchain no longer builds"

    This reverts commit e764f47.
    Fixes rust-lang#61174.
    Bastian Germann committed May 28, 2019
    Configuration menu
    Copy the full SHA
    a552e7a View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Fix ICE with struct ctors and const generics.

    This commit fixes a ICE where struct constructors were resulting in an
    ICE with const generics. Previously, a `match` in `type_of` did not have
    an arm for the `DefKind::Ctor` resolutions and therefore would assume
    that the type did not have generics.
    davidtwco committed May 29, 2019
    Configuration menu
    Copy the full SHA
    41aaf7b View commit details
    Browse the repository at this point in the history
  2. Update all s3 URLs used on CI with subdomains

    Ensure that they're all forwards-compatible with AWS updates happening
    next year by ensuring the bucket name shows up in the domain name.
    
    Closes rust-lang#61168
    alexcrichton committed May 29, 2019
    Configuration menu
    Copy the full SHA
    3eda151 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed8a4d5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5f4f368 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d72ac3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eafa3a8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    998ef68 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Rollup merge of rust-lang#60802 - euclio:pulldown-cmark-panic, r=Guil…

    …laumeGomez
    
    upgrade rustdoc's `pulldown-cmark` to 0.5.2
    
    Fixes rust-lang#60482.
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    040af62 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#60839 - davidtwco:const-generics-struct-cto…

    …r, r=varkor
    
    Fix ICE with struct ctors and const generics.
    
    Fixes rust-lang#60818.
    
    r? @varkor
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    933c773 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#60850 - SimonSapin:unguarded, r=alexcrichton

    Stabilize RefCell::try_borrow_unguarded
    
    Servo has been using this since servo/servo#23196 to add a runtime check to some unsafe code, as discussed in PR rust-lang#59211. Stabilizing would help do more of the same in libraries that also have users on Stable.
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    74b3593 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#61231 - pnkfelix:issue-59548-linkage-diagno…

    …stic, r=petrochenkov
    
    Fix linkage diagnostic so it doesn't ICE for external crates
    
    Fix linkage diagnostic so it doesn't ICE for external crates
    
    (As a drive-by improvement, improved the diagnostic to indicate *why* `*const T` or `*mut T` is required.)
    
    Fix rust-lang#59548
    Fix rust-lang#61232
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    6351267 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#61244 - RalfJung:box, r=rkruppe

    Box::into_vec: use Box::into_raw instead of mem::forget
    
    `Box::into_raw` does, in one step, turn the `Box` into a raw ptr and avoid deallocation.  Seems cleaner than separating the two.
    
    Also, `mem::forget` gets the `Box` with a `noalias` argument, but it is not actually correct that this is an exclusive pointer. So a stricter version of Stacked Borrows would complain here. (I can't actually make Stacked Borrows that strict yet though due to other issues.)
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    1b66a13 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#61279 - llogiq:implicit-option-main-doctest…

    …s, r=GuillaumeGomez
    
    implicit `Option`-returning doctests
    
    This distinguishes `Option` and `Result`-returning doctests with implicit `main` method, where the former tests must end with `Some(())`.
    
    Open question: Does this need a feature gate?
    
    r? @GuillaumeGomez
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    07d0b57 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#61280 - bgermann:master, r=alexcrichton

    Revert "Disable solaris target since toolchain no longer builds"
    
    This reverts commit e764f47.
    Fixes rust-lang#61174.
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    8b55529 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#61284 - alexcrichton:less-s3, r=pietroalbini

    Update all s3 URLs used on CI with subdomains
    
    Ensure that they're all forwards-compatible with AWS updates happening
    next year by ensuring the bucket name shows up in the domain name.
    
    Closes rust-lang#61168
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    8cb5885 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#61321 - Centril:is_keyword_ahead, r=petroch…

    …enkov
    
    libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.
    
    Introduces:
    ```rust
        /// Returns whether any of the given keywords are `dist` tokens ahead of the current one.
        fn is_keyword_ahead(&self, dist: usize, kws: &[Symbol]) -> bool {
            self.look_ahead(dist, |t| kws.iter().any(|&kw| t.is_keyword(kw)))
        }
    ```
    
    r? @oli-obk
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    bc3f373 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#61322 - pietroalbini:debug-windows-submodul…

    …e-cloning, r=alexcrichton
    
    ci: display more debug information in the init_repo script
    
    I'm *really* confused about the error message [while cloning submodules on Windows on Azure](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/295/logs/506):
    
    ```
    /usr/bin/tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options
    Try '/usr/bin/tar --help' or '/usr/bin/tar --usage' for more information.
    ```
    
    It doesn't make sense for it to execute a command without any of those flags since they're clearly added:
    
    https://github.com/rust-lang/rust/blob/81970852e172c04322cbf8ba23effabeb491c83c/src/ci/init_repo.sh#L45
    
    So this adds `set -x` to the script to hopefully catch what command it's executing.
    
    r? @alexcrichton
    cc rust-lang#61301
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    6282fae View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#61333 - varkor:apit-const-param-ice, r=este…

    …bank
    
    Fix ICE with APIT in a function with a const parameter
    
    Fixes rust-lang#60953.
    Centril authored May 30, 2019
    Configuration menu
    Copy the full SHA
    528972a View commit details
    Browse the repository at this point in the history