Rollup of 8 pull requests #63090
Merged
Rollup of 8 pull requests #63090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double dropping is unsound (e.g. rust-lang#60977). This commit documents the fact that `ManuallyDrop::drop` should not be called multiple times on the same instance, as it might not be immediately obvious that this counts as a use of uninitialized data.
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Lint attributes on function arguments Fixes rust-lang#61238. cc rust-lang#60406
Document that ManuallyDrop::drop should not called more than once Double dropping is unsound (e.g. rust-lang#60977). This commit documents the fact that `ManuallyDrop::drop` should not be called multiple times on the same instance, as it might not be immediately obvious that this counts as a use of uninitialized data.
…uillaumeGomez Update minifier-rs version The `main.js` file size goes from 52868 to 50134. A few fixes have been included as well (no more eluded parts of js files). r? @QuietMisdreavus
…Centril Explicit error message for async recursion. Attempt at clearer error message when async recusion is attempted. In response to rust-lang#62539 (and rust-lang#53690).
Avoid ICE when suggestion span is at Eof Fix rust-lang#62973.
SystemTime docs: recommend Instant for elapsed time Introduction to `SystemTime` mentions problems with non-monotonic clocks, but individual methods don't. For benefit of users who jump directly to method's documentation, also recommend `Instant` in `elapsed` and `duration_since`. `SystemTime::elapsed()` docs overpromised the elapsed time. It's not elapsed time, but a difference between two clocks.
…lacrum tidy: Cleanup the directory whitelist Some entries were outdated - pre-"llvm-project", pre-"crates.io", pre-"Cargo.toml outside of src". Some entries were unnecessary - `owning_ref` could be fixed and directories outside of `src` are not visited by tidy at all. r? @Mark-Simulacrum
Remove anonymous_parameters from unrelated test The parsing of anonymous_parameters is sufficiently covered by: - [src/test/ui/issues/issue-13105.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-13105.rs) - [src/test/ui/issues/issue-13775.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-13775.rs) - [src/test/ui/issues/issue-34074.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-34074.rs) Removing anonymous_parameters from this test means fewer exclusions for me in dtolnay/syn#644.
|
@bors r+ p=8 rollup=never |
|
📌 Commit 29c3778 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 28, 2019
Rollup of 8 pull requests Successful merges: - #61856 (Lint attributes on function arguments) - #62360 (Document that ManuallyDrop::drop should not called more than once) - #62392 (Update minifier-rs version) - #62871 (Explicit error message for async recursion.) - #62995 (Avoid ICE when suggestion span is at Eof) - #63053 (SystemTime docs: recommend Instant for elapsed time) - #63081 (tidy: Cleanup the directory whitelist) - #63088 (Remove anonymous_parameters from unrelated test) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 29, 2019
Tested on commit rust-lang/rust@c7312fe. Direct link to PR: <rust-lang/rust#63090> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost