Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hygiene of alloc::format! #64060

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Improve hygiene of alloc::format! #64060

merged 1 commit into from
Sep 11, 2019

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Sep 1, 2019 •
edited
Loading

format now uses format_args though a __export module, as described in #63687 (comment).

Fixes #63687

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
@petrochenkov petrochenkov mentioned this pull request Sep 1, 2019
Closed
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-01T11:13:48.8524332Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T11:13:48.8720632Z ##[command]git config gc.auto 0
2019-09-01T11:13:48.8798078Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T11:13:48.8853842Z ##[command]git config --get-all http.proxy
2019-09-01T11:13:48.8993615Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64060/merge:refs/remotes/pull/64060/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@dtolnay
Copy link
Member

dtolnay commented Sep 2, 2019

@bors r+

But I would like to see the hygienic suggestion from #63687 (comment) implemented. That approach of $crate::__export::... is common practice in the library ecosystem.

@bors
Copy link
Contributor

bors commented Sep 2, 2019

📌 Commit dc447e06217cd8c206c62eb838a7ede4d0b4002b has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2019
@petrochenkov
Copy link
Contributor Author

@bors r-
(I'll change the PR to use __export.)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2019
@JohnCSimon
Copy link
Member

Ping from triage -
@petrochenkov - What is the status of this PR?
Thank you.

@petrochenkov
Copy link
Contributor Author

Will update in a couple of days.

@petrochenkov
Copy link
Contributor Author

Updated.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2019
@tesuji
Copy link
Contributor

tesuji commented Sep 8, 2019

Should we change the PR title too?

@petrochenkov petrochenkov changed the title Revert "hygienization" of alloc::format! Improve hygiene of alloc::format! Sep 8, 2019
@petrochenkov petrochenkov mentioned this pull request Sep 10, 2019
Closed
@tmandry
Copy link
Member

tmandry commented Sep 10, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2019

📌 Commit d42e603 has been approved by tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2019
@bors
Copy link
Contributor

bors commented Sep 10, 2019

⌛ Testing commit d42e603 with merge ce8b01ce2bba41f767ee49ad7b6df71569c11d74...

tmandry added a commit to tmandry/rust that referenced this pull request Sep 10, 2019
@tmandry
Rollup merge of rust-lang#64060 - petrochenkov:unstdhyg, r=tmandry
3990b40 
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@tmandry tmandry mentioned this pull request Sep 10, 2019
Closed
@tmandry
Copy link
Member

tmandry commented Sep 10, 2019

@bors retry rolled up

@bors
Copy link
Contributor

bors commented Sep 10, 2019

⌛ Testing commit d42e603 with merge 679d12dbf8dd935eb09eb6067cc1523bbd9d5536...

Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
@Centril
Rollup merge of rust-lang#64060 - petrochenkov:unstdhyg, r=tmandry
659ef20 
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@Centril Centril mentioned this pull request Sep 10, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 10, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Sep 10, 2019
@bors
Auto merge of #64368 - Centril:rollup-4s8ko6f, r=Centril
98d6df5 
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Sep 11, 2019

⌛ Testing commit d42e603 with merge 7e56c231fc7cfb03fffd21950ffe7988e8626caa...

Centril added a commit to Centril/rust that referenced this pull request Sep 11, 2019
@Centril
Rollup merge of rust-lang#64060 - petrochenkov:unstdhyg, r=tmandry
e757d33 
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@Centril Centril mentioned this pull request Sep 11, 2019
Merged
@Centril
Copy link
Contributor

Centril commented Sep 11, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Sep 11, 2019
@bors
Auto merge of #64369 - Centril:rollup-g875ozi, r=Centril
74d5c70 
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64326 (Fixed documentation within c_str::from_ptr)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Sep 11, 2019

⌛ Testing commit d42e603 with merge 74d5c70...

@bors bors merged commit d42e603 into rust-lang:master Sep 11, 2019
@teohhanhui teohhanhui mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gfx_device_gl 0.16.1 broken on latest nightly
8 participants
@petrochenkov @rust-highfive @dtolnay @bors @JohnCSimon @tesuji @tmandry @Centril