documentation for AtomicPtr CAS operations #64349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 7ad44c7 has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 10, 2019
…r, r=cramertj documentation for AtomicPtr CAS operations The examples in the documentation for AtomicPtr CAS operations only show code that does *not* perform the CAS operation. I suggest to change them so that they actually do exchange the AtomicPtr's value.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 10, 2019
…r, r=cramertj documentation for AtomicPtr CAS operations The examples in the documentation for AtomicPtr CAS operations only show code that does *not* perform the CAS operation. I suggest to change them so that they actually do exchange the AtomicPtr's value.
bors
added a commit
that referenced
this pull request
Sep 10, 2019
Rollup of 6 pull requests Successful merges: - #64060 (Improve hygiene of `alloc::format!`) - #64072 (Replace file_stem by file_name in rustdoc markdown) - #64085 (Tweak unsatisfied HRTB errors) - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn) - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi) - #64349 (documentation for AtomicPtr CAS operations) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 11, 2019
…r, r=cramertj documentation for AtomicPtr CAS operations The examples in the documentation for AtomicPtr CAS operations only show code that does *not* perform the CAS operation. I suggest to change them so that they actually do exchange the AtomicPtr's value.
bors
added a commit
that referenced
this pull request
Sep 11, 2019
Rollup of 6 pull requests Successful merges: - #64060 (Improve hygiene of `alloc::format!`) - #64072 (Replace file_stem by file_name in rustdoc markdown) - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn) - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi) - #64326 (Fixed documentation within c_str::from_ptr) - #64349 (documentation for AtomicPtr CAS operations) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in the documentation for AtomicPtr CAS operations only show code that does not perform the CAS operation. I suggest to change them so that they actually do exchange the AtomicPtr's value.