Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ICE on ReFree region on where clause #64938

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Oct 1, 2019

Fix #64855.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2019
@estebank
Copy link
Contributor Author

estebank commented Oct 1, 2019

r? @matthewjasper, as @petrochenkov is on vacation.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@estebank estebank changed the title Avoid ICE on ReFree region from malformed code Avoid ICE on ReFree region on where clause Oct 2, 2019
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 3, 2019

📌 Commit de81565 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 3, 2019
bors added a commit that referenced this pull request Oct 3, 2019
Rollup of 5 pull requests

Successful merges:

 - #64690 (proc_macro API: Expose `macro_rules` hygiene)
 - #64749 (Fix most remaining Polonius test differences)
 - #64938 (Avoid ICE on ReFree region on where clause)
 - #64999 (extract expected return type for async fn generators)
 - #65037 (`#[track_caller]` feature gate (RFC 2091))

Failed merges:

r? @ghost
@Centril
Copy link
Contributor

Centril commented Oct 3, 2019

@bors p=2 (canary for seeing cause of failure in #65053 (comment))

@bors
Copy link
Contributor

bors commented Oct 3, 2019

⌛ Testing commit de81565 with merge 032a53a...

bors added a commit that referenced this pull request Oct 3, 2019
Avoid ICE on ReFree region on where clause

Fix #64855.
@bors
Copy link
Contributor

bors commented Oct 3, 2019

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing 032a53a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 3, 2019
@bors bors merged commit de81565 into rust-lang:master Oct 3, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #64938!

Tested on commit 032a53a.
Direct link to PR: #64938

🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 3, 2019
Tested on commit rust-lang/rust@032a53a.
Direct link to PR: <rust-lang/rust#64938>

🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE "unexpected region in outlives inference: ReEmpty"
6 participants