-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract expected return type for async fn generators #64999
extract expected return type for async fn generators #64999
Conversation
r=me if you like with comments addressed. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
(with respect, you're not presently a compiler reviewer) |
src/test/ui/async-await/async-block-control-flow-static-semantics.stderr
Show resolved
Hide resolved
r=me with travis. |
@bors r=cramertj |
📌 Commit a96bce7 has been approved by |
@bors r=cramertj |
📌 Commit a807032 has been approved by |
Should we p=1 this? (I wonder if p=1 should be general policy for beta-nominated PRs) (My reasoning is that if we are considering a backport, we want it on nightly ASAP to know about possible complications.) |
I'll just include it in the next rollup which is even faster than p=1. ;) EDIT: ...and done... see below. :) |
…rn-inference, r=cramertj extract expected return type for async fn generators Fixes rust-lang#60424 cc @Centril, I know you've been eager to see this fixed. r? @cramertj
…rn-inference, r=cramertj extract expected return type for async fn generators Fixes rust-lang#60424 cc @Centril, I know you've been eager to see this fixed. r? @cramertj
Rollup of 5 pull requests Successful merges: - #64690 (proc_macro API: Expose `macro_rules` hygiene) - #64749 (Fix most remaining Polonius test differences) - #64938 (Avoid ICE on ReFree region on where clause) - #64999 (extract expected return type for async fn generators) - #65037 (`#[track_caller]` feature gate (RFC 2091)) Failed merges: r? @ghost
@bors p=3 (canary for seeing cause of failure in #65053 (comment)) |
/// type of the `async fn` -- that is, the return type that the | ||
/// user specified. The "desugared" return type is a `impl | ||
/// Future<Output = T>`, so we do this by searching through the | ||
/// obligations to extract the `T`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leave a FIXME/open an issue somewhere about generalizing this so it can rely entirely on the impl
s involved and not have to know about the Future
trait at all?
(This would be long-term and probably significantly more complicated than this targeted fix)
☀️ Test successful - checks-azure |
discussed at rustc meeting. we're going to leave it beta-nominated for another week so that it gets exercised a bit on nightly before we jump in. |
Seems this PR introduced #65159. |
If we do backport, we would want to backport #65235 too |
T-compiler discussed. Decided to let this ride-the-trains. declined for beta-backport. (For future github readers: If you need a work-around, its documented in description on #60424) |
Fixes #60424
cc @Centril, I know you've been eager to see this fixed.
r? @cramertj