Rollup of 7 pull requests #67426

Centril · 2019-12-19T14:59:23Z

Successful merges:

Normalize ident #66670 (Normalize ident)
Remove a const-if-hack in RawVec #66755 (Remove a const-if-hack in RawVec)
Use structured suggestion for disambiguating method calls #67127 (Use structured suggestion for disambiguating method calls)
add string.insert benchmarks #67281 (add string.insert benchmarks)
Remove now-redundant range check on u128 -> f32 casts #67328 (Remove now-redundant range check on u128 -> f32 casts)
Fix unresolved type span inside async object #67392 (Fix unresolved type span inside async object)
Fix internal documentation typo #67421 (Fix internal documentation typo)

Failed merges:

This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions. Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need. Closes rust-lang#51872

Normalize ident Perform unicode normalization on identifiers. Resolving the first bullet point in rust-lang#55467.

@ecstatic-morse

…morse Remove a const-if-hack in RawVec r? @ecstatic-morse cc @Centril

…=varkor Use structured suggestion for disambiguating method calls Fix rust-lang#65635.

…xcrichton add string.insert benchmarks This adds benchmarks for `String::insert` and `String::insert_str`

…atthewjasper Remove now-redundant range check on u128 -> f32 casts This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions. Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need. Closes rust-lang#51872

@estebank

Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)

@Centril

Fix internal documentation typo r? @Centril

Centril · 2019-12-19T14:59:35Z

@bors r+ p=7 rollup=never

bors · 2019-12-19T14:59:37Z

📌 Commit 4ff4d6c has been approved by Centril

bors · 2019-12-19T18:19:02Z

⌛ Testing commit 4ff4d6c with merge d353e5e70db245d34b75d1841f4032ad57f61d0d...

rust-highfive · 2019-12-19T18:40:41Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-19T18:38:59.1668888Z Build completed successfully in 0:01:41
2019-12-19T18:38:59.1679313Z + /scripts/validate-toolstate.sh
2019-12-19T18:38:59.1740667Z Cloning into 'rust-toolstate'...
2019-12-19T18:38:59.7015712Z Traceback (most recent call last):
2019-12-19T18:38:59.7015911Z   File "../../src/tools/publish_toolstate.py", line 303, in <module>
2019-12-19T18:38:59.7015990Z     cur_datetime
2019-12-19T18:38:59.7016081Z   File "../../src/tools/publish_toolstate.py", line 182, in update_latest
2019-12-19T18:38:59.7016872Z     for os in ['windows', 'linux']
2019-12-19T18:38:59.7016976Z   File "../../src/tools/publish_toolstate.py", line 182, in <dictcomp>
2019-12-19T18:38:59.7017245Z     for os in ['windows', 'linux']
2019-12-19T18:38:59.7017327Z   File "../../src/tools/publish_toolstate.py", line 111, in read_current_status
2019-12-19T18:38:59.7017900Z     (commit, status) = line.split('\t', 1)
2019-12-19T18:38:59.7018004Z ValueError: need more than 1 value to unpack
2019-12-19T18:38:59.7052713Z   local time: Thu Dec 19 18:38:59 UTC 2019
2019-12-19T18:39:00.2254762Z   network time: Thu, 19 Dec 2019 18:39:00 GMT
2019-12-19T18:39:00.2259016Z == end clock drift check ==
2019-12-19T18:39:02.2252179Z 
2019-12-19T18:39:02.2252179Z 
2019-12-19T18:39:02.2426917Z ##[error]Bash exited with code '1'.
2019-12-19T18:39:02.2463725Z ##[section]Starting: Checkout
2019-12-19T18:39:02.2466195Z ==============================================================================
2019-12-19T18:39:02.2466466Z Task         : Get sources
2019-12-19T18:39:02.2466572Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-19T18:40:51Z

💔 Test failed - checks-azure

Centril · 2019-12-19T18:44:42Z

Infra stuff are broken ^--, @bors treeclosed=100

Centril · 2019-12-19T18:44:52Z

@bors retry

@ghost

Rollup of 7 pull requests Successful merges: - rust-lang#66670 (Normalize ident) - rust-lang#66755 (Remove a const-if-hack in RawVec) - rust-lang#67127 (Use structured suggestion for disambiguating method calls) - rust-lang#67281 (add string.insert benchmarks) - rust-lang#67328 (Remove now-redundant range check on u128 -> f32 casts) - rust-lang#67392 (Fix unresolved type span inside async object) - rust-lang#67421 (Fix internal documentation typo) Failed merges: r? @ghost

@ghost

Rollup of 7 pull requests Successful merges: - rust-lang#66670 (Normalize ident) - rust-lang#66755 (Remove a const-if-hack in RawVec) - rust-lang#67127 (Use structured suggestion for disambiguating method calls) - rust-lang#67281 (add string.insert benchmarks) - rust-lang#67328 (Remove now-redundant range check on u128 -> f32 casts) - rust-lang#67392 (Fix unresolved type span inside async object) - rust-lang#67421 (Fix internal documentation typo) Failed merges: r? @ghost

@ghost

Rollup of 3 pull requests Successful merges: - #67351 (Set release channel on non-dist builders) - #67426 (Rollup of 7 pull requests) - #67432 (Fix toolstate history format) Failed merges: r? @ghost

@ghost

Rollup of 7 pull requests Successful merges: - rust-lang#66670 (Normalize ident) - rust-lang#66755 (Remove a const-if-hack in RawVec) - rust-lang#67127 (Use structured suggestion for disambiguating method calls) - rust-lang#67281 (add string.insert benchmarks) - rust-lang#67328 (Remove now-redundant range check on u128 -> f32 casts) - rust-lang#67392 (Fix unresolved type span inside async object) - rust-lang#67421 (Fix internal documentation typo) Failed merges: r? @ghost

@ghost

Rollup of 3 pull requests Successful merges: - #67351 (Set release channel on non-dist builders) - #67426 (Rollup of 7 pull requests) - #67432 (Fix toolstate history format) Failed merges: r? @ghost

estebank and others added 23 commits December 11, 2019 17:42

Use structured suggestion for disambiguating method calls

3980342

Fix rust-lang#65635.

review comments

8c4f1d5

Remove now-redundant range check on u128 -> f32 casts

6ad0b55

This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions. Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need. Closes rust-lang#51872

Add benchmarks for string::insert(_str)

c6321a4

add debuginfo in generator_interior

c1241bf

record previous unresolve span for generator error reporting

ff4f6a1

Remove a const-if-hack in RawVec

17aa0cb

remove a bit more hackery

3ec3fca

use usize::MAX instead of !0

baaf864

fix import

951f041

add fixme

2535435

no need to bootstrap

7d26811

Normalize identifiers in librustc_parse.

35af4e2

Add a test and bless existing test case.

5a75934

Add unicode-normalization to whitelist.

49f3bc9

Fix documentation typo

bfc02bd

Rollup merge of rust-lang#66670 - crlf0710:normalize_ident, r=estebank

02206dc

Normalize ident Perform unicode normalization on identifiers. Resolving the first bullet point in rust-lang#55467.

Rollup merge of rust-lang#66755 - mark-i-m:const-vec-new, r=ecstatic-…

208f353

…morse Remove a const-if-hack in RawVec r? @ecstatic-morse cc @Centril

Rollup merge of rust-lang#67127 - estebank:disambiguate-suggestion, r…

8c15656

…=varkor Use structured suggestion for disambiguating method calls Fix rust-lang#65635.

Rollup merge of rust-lang#67281 - llogiq:nonoverlapping-insert, r=ale…

4254d29

…xcrichton add string.insert benchmarks This adds benchmarks for `String::insert` and `String::insert_str`

Rollup merge of rust-lang#67421 - LeSeulArtichaut:patch-1, r=Centril

4ff4d6c

Fix internal documentation typo r? @Centril

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 19, 2019

Centril added the rollup A PR which is a rollup label Dec 19, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2019

Centril mentioned this pull request Dec 19, 2019

Add a raw "address of" operator #64588

Merged

Centril mentioned this pull request Dec 19, 2019

Rollup of 2 pull requests #67433

Closed

Centril mentioned this pull request Dec 19, 2019

Rollup of 3 pull requests #67434

Closed

Mark-Simulacrum mentioned this pull request Dec 19, 2019

Rollup of 3 pull requests #67435

Closed

Mark-Simulacrum closed this Dec 19, 2019

Centril deleted the rollup-rswp4rf branch December 23, 2019 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #67426

Rollup of 7 pull requests #67426

Centril commented Dec 19, 2019

Centril commented Dec 19, 2019

bors commented Dec 19, 2019

bors commented Dec 19, 2019

rust-highfive commented Dec 19, 2019

bors commented Dec 19, 2019

Centril commented Dec 19, 2019

Centril commented Dec 19, 2019

Rollup of 7 pull requests #67426

Rollup of 7 pull requests #67426

Conversation

Centril commented Dec 19, 2019

Centril commented Dec 19, 2019

bors commented Dec 19, 2019

bors commented Dec 19, 2019

rust-highfive commented Dec 19, 2019

bors commented Dec 19, 2019

Centril commented Dec 19, 2019

Centril commented Dec 19, 2019