Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the matches! macro #67659

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Stabilize the matches! macro #67659

merged 1 commit into from
Dec 28, 2019

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Dec 27, 2019
@rust-highfive
Copy link
Collaborator

r? @rkruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2019
@hanna-kruppe
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2019

📌 Commit 1c572a2 has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2019
@jonas-schievink jonas-schievink added this to the 1.42 milestone Dec 27, 2019
oli-obk added a commit to oli-obk/rust that referenced this pull request Dec 27, 2019
@oli-obk
Rollup merge of rust-lang#67659 - SimonSapin:matches, r=rkruppe
335c887 
Stabilize the `matches!` macro

Fixes rust-lang#65721

FCP: rust-lang#65721 (comment)
@oli-obk oli-obk mentioned this pull request Dec 27, 2019
Merged
bors added a commit that referenced this pull request Dec 28, 2019
@bors
Auto merge of #67670 - oli-obk:rollup-2dp08sd, r=oli-obk
3a087ad 
Rollup of 15 pull requests

Successful merges:

 - #65244 (add IntoFuture trait and support for await)
 - #67576 (reuse `capacity` variable in slice::repeat)
 - #67588 (Use NonNull in slice::Iter and slice::IterMut.)
 - #67594 (Update libc to 0.2.66)
 - #67602 (Use issue = "none" instead of "0" in intrinsics)
 - #67604 (Add Scalar::to_(u|i)16 methods)
 - #67617 (Remove `compiler_builtins_lib` documentation)
 - #67621 (Use the correct type for static qualifs)
 - #67629 (Remove redundant link texts)
 - #67632 (Convert collapsed to shortcut reference links)
 - #67633 (Update .mailmap)
 - #67635 (Document safety of Path casting)
 - #67654 (Add regression test for old NLL ICE)
 - #67659 (Stabilize the `matches!` macro)
 - #67664 (Fix some mailmap entries)

Failed merges:

r? @ghost
@bors bors merged commit 1c572a2 into rust-lang:master Dec 28, 2019
@tesuji tesuji mentioned this pull request Dec 28, 2019
Closed
@SimonSapin SimonSapin deleted the matches branch December 28, 2019 10:26
@bilelmoussaoui bilelmoussaoui mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hanna-kruppe hanna-kruppe

Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.

Tracking issue for the matches! macro
5 participants
@SimonSapin @rust-highfive @hanna-kruppe @bors @jonas-schievink