Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak obligation error output #68377

Merged
merged 23 commits into from
Feb 4, 2020
Merged

Tweak obligation error output #68377

merged 23 commits into from
Feb 4, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 20, 2020 •
edited
Loading

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the fn-obligations-spans branch from e651f86 to fbb2a90 Compare January 20, 2020 03:22
@estebank estebank force-pushed the fn-obligations-spans branch from fbb2a90 to 288ffa9 Compare January 25, 2020 22:28
@estebank
Copy link
Contributor Author

ping

@estebank estebank force-pushed the fn-obligations-spans branch from ae5611c to de4b03d Compare January 30, 2020 03:12
@estebank
Copy link
Contributor Author

cc @rust-lang/wg-diagnostics just because I'm stoked about the result :D

oli-obk
oli-obk reviewed Jan 30, 2020
View reviewed changes
src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved
src/librustc/traits/object_safety.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-20692.stderr Outdated Show resolved Hide resolved
src/test/ui/wf/wf-unsafe-trait-obj-match.stderr Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Jan 30, 2020

The new spans are awesome!

matthewjasper
matthewjasper reviewed Jan 30, 2020
View reviewed changes
src/librustc/traits/object_safety.rs Outdated Show resolved Hide resolved
src/librustc/traits/object_safety.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jan 31, 2020

⌛ Trying commit 532f7c2ff15169402902ddcca71fc13833c3fe99 with merge 5a6609e6dd45556e226d848cf5f6b92301748bd9...

@bors
Copy link
Contributor

bors commented Jan 31, 2020

☀️ Try build successful - checks-azure
Build commit: 5a6609e6dd45556e226d848cf5f6b92301748bd9 (5a6609e6dd45556e226d848cf5f6b92301748bd9)

@rust-timer
Copy link
Collaborator

Queued 5a6609e6dd45556e226d848cf5f6b92301748bd9 with parent 5371ddf, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 5a6609e6dd45556e226d848cf5f6b92301748bd9, comparison URL.

This was referenced Feb 1, 2020
Closed
Closed
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the fn-obligations-spans branch from a218555 to 009dc5f Compare February 2, 2020 10:32
@bors

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the fn-obligations-spans branch from 009dc5f to 342db71 Compare February 2, 2020 19:56
@estebank estebank mentioned this pull request Feb 2, 2020
Open
@estebank
Copy link
Contributor Author

estebank commented Feb 2, 2020

Sorry for this PR becoming so big 😬, it's just addressing a bunch of intimately related issues. Each commit builds on the previous one.

@estebank estebank force-pushed the fn-obligations-spans branch from 34990c8 to 865216b Compare February 2, 2020 21:46
@estebank estebank mentioned this pull request Feb 2, 2020
Closed
oli-obk
oli-obk approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a wording, then this lgtm

src/test/ui/associated-const/associated-const-in-trait.stderr Outdated Show resolved Hide resolved
@estebank estebank force-pushed the fn-obligations-spans branch from 5439b6e to 0e58411 Compare February 3, 2020 18:54
@estebank
Copy link
Contributor Author

estebank commented Feb 3, 2020

Just a wording, then this lgtm

Is that r=oli-obk? 😅

@oli-obk
Copy link
Contributor

oli-obk commented Feb 4, 2020

@bors r+

yes :D I'll communicate that more clearly next time

@bors
Copy link
Contributor

bors commented Feb 4, 2020

📌 Commit 0e58411 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2020
@bors
Copy link
Contributor

bors commented Feb 4, 2020

⌛ Testing commit 0e58411 with merge 5b0caef...

bors added a commit that referenced this pull request Feb 4, 2020
@bors
Auto merge of #68377 - estebank:fn-obligations-spans, r=oli-obk
5b0caef 
Tweak obligation error output

- Point at arguments or output when fn obligations come from them, or ident when they don't
- Point at `Sized` bound (fix #47990)
- When object unsafe trait uses itself in associated item suggest using `Self` (fix #66424, fix #33375, partially address #38376, cc #61525)
-  Point at reason in object unsafe trait with `Self` in supertraits or `where`-clause (cc #40533, cc #68377)
- On implicit type parameter `Sized` obligations, suggest `?Sized` (fix #57744, fix #46683)
@bors
Copy link
Contributor

bors commented Feb 4, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 5b0caef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2020
@bors bors mentioned this pull request Feb 4, 2020
Merged
@bors bors merged commit 0e58411 into rust-lang:master Feb 4, 2020
@bors bors mentioned this pull request Feb 4, 2020
Merged
@estebank estebank mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

@Centril Centril Centril left review comments

@oli-obk oli-obk oli-obk approved these changes

Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
7 participants
@estebank @rust-highfive @oli-obk @rust-timer @bors @Centril @matthewjasper