Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak obligation error output #68377

Merged
merged 23 commits into from
Feb 4, 2020
Merged

Tweak obligation error output #68377

merged 23 commits into from
Feb 4, 2020

Commits on Feb 2, 2020

  1. Point at arguments or output when fn obligations come from them, or i… 

    …dent when they don't
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    fca5c64 View commit details
    Browse the repository at this point in the history

  2. Point at Sized bound

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    1c9242f View commit details
    Browse the repository at this point in the history

  3. When object unsafe trait uses itself in associated item suggest using… 

    … `Self`
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    d72bcdb View commit details
    Browse the repository at this point in the history

  4. fix test

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    0eb29d1 View commit details
    Browse the repository at this point in the history

  5. review comments

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    d137b7a View commit details
    Browse the repository at this point in the history

  6. Tweak Self: Sized restriction diagnostic output

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    4b2f1db View commit details
    Browse the repository at this point in the history

  7. Point at the Sized obligation in where clauses

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    972ae5a View commit details
    Browse the repository at this point in the history

  8. Point at return type obligations instead of at fn ident

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    8d48597 View commit details
    Browse the repository at this point in the history

  9. Use more accurate failed predicate spans

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    6870f79 View commit details
    Browse the repository at this point in the history

  10. Slight rewording of diagnostic message

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    144e259 View commit details
    Browse the repository at this point in the history

  11. Remove duplicated code

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    132921b View commit details
    Browse the repository at this point in the history

  12. review comments

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    06fea92 View commit details
    Browse the repository at this point in the history

  13. Point at Sized requirements 

    Make rust-lang#47990 easier to understand
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    3ca1c5d View commit details
    Browse the repository at this point in the history

  14. Wording changes to object unsafe trait errors 

    Stemming from the thread at https://twitter.com/indygreg/status/1223279056398929920
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    413bfa4 View commit details
    Browse the repository at this point in the history

  15. Use more appropriate spans on object unsafe traits and provide struct… 

    …ured suggestions when possible
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    a52ec87 View commit details
    Browse the repository at this point in the history

  16. add tests for structured suggestion

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    542130b View commit details
    Browse the repository at this point in the history

  17. Suggest ?Sized on type parameters

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    cb6dfea View commit details
    Browse the repository at this point in the history

  18. Remove duplicated code

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    d216b73 View commit details
    Browse the repository at this point in the history

  19. Account for ?Sized type parameter bounds

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    342db71 View commit details
    Browse the repository at this point in the history

  20. fix rebase

    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    16d935e View commit details
    Browse the repository at this point in the history

  21. Point at reason in object unsafe trait with Self in supertraits or … 

    …`where`-clause
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    865216b View commit details
    Browse the repository at this point in the history

  22. Deal with spans showing std lib 

    Address rust-lang#53081
    @estebank
    estebank committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    b9c125a View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Change wording for object unsafe because of assoc const

    @estebank
    estebank committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    0e58411 View commit details
    Browse the repository at this point in the history