Remove a few unused objects #69059
Merged
Remove a few unused objects #69059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Feb 11, 2020
|
Sooo I guess I'll remove that bit again shortly ^^. |
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 11, 2020
Impl DefaultCallbacks on our side cc rust-lang/rust#69059 (comment) changelog: none
|
|
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 11, 2020
Impl DefaultCallbacks on our side cc rust-lang/rust#69059 (comment) changelog: none
|
I do have a PR open which make use of |
|
Thanks for the feedback, I'll update the PR shortly. |
|
Done. |
|
@bors r+ rollup |
|
📌 Commit d8544ce has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 12, 2020
Remove a few unused objects As far as I can tell, these won't be missed: - `infer::region_constraints::ConstraintInfo` - `driver::DefaultCallbacks` - ~~`hir::intravisit::ParDeepVisitor`~~
bors
added a commit
that referenced
this pull request
Feb 12, 2020
Rollup of 8 pull requests Successful merges: - #67585 (Improve `char::is_ascii_*` codegen) - #68914 (Speed up `SipHasher128`.) - #68994 (rustbuild: include channel in sanitizers installed name) - #69032 (ICE in nightly-2020-02-08: handle TerminatorKind::Yield in librustc_mir::transform::promote_consts::Validator method) - #69034 (parser: Remove `Parser::prev_token_kind`) - #69042 (Remove backtrace header text) - #69059 (Remove a few unused objects) - #69089 (Properly use the darwin archive format on Apple targets) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, these won't be missed:
infer::region_constraints::ConstraintInfodriver::DefaultCallbackshir::intravisit::ParDeepVisitor