-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate word in core docs #6961
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e off a librustc build. Smallintmap was being populated with sparse keys during ast deserialization.
Shaves off ~600MB of memory while compiling rustc
* Add a short section and an example illustrating the use of ARC. * Header for the section of Future changed to be more descriptive: "Backgrounding computations: Futures".
Smallintmap was being populated with sparse keys during ast deserialization.
Via my super-accurate timing (`/usr/bin/time -l`), I get 2431119360 => 1884430336 == ~520MB Closes #6637.
Per the recommendation of the now-removed FIXME.
r? @thestinger As called for in #4994
The compiler guarantees that there are no other references to a unique pointer when it's passed by-value to a function. The existence of the header and annihilator don't matter since it's not relevant to the call: > For a call to the parent function, dependencies between memory references from before or after the call and from those during the call are “irrelevant” to the noalias keyword for the arguments and return value used in that call. @graydon's tracing garbage collector stores the metadata outside of the boxes, so that won't be a problem. I'm unsure if updating the header while inside a function where it's marked as `noalias` would be a problem anyway since you never actually read or write to the header. @nikomatsakis: r?
This works with pandoc linked against highlighting-kate >= 0.5.3.8. It seems to just be a no-op with earlier versions, because I successfully ran this through `try`. This also fixes some consistency issues (like making `Example`/`Examples` always a header and always using three tildes).
I think settings like this should be left up to the user.
it can alias `&const` and `@mut`
…matsakis it can alias `&const` and `@mut`
Also as a bonus this fixes #6767
…terns into borrow checker and generalize what moves are allowed. Fixes a nasty bug or two in the pattern move checking code. Unifies dataflow code used for initialization and other things. First step towards once fns. Everybody wins. Fixes #4384. Fixes #4715. cc once fns (#2202), optimizing local moves (#5016).
Write a conservative .mailmap as an example for contributors to write their preferred names/ email addresses to. This patch makes no assumptions about the same author using different email addresses, and only collects cases where the full-name of the person is spelt differently for the same email address. Verify with: $ git shortlog -se | cut -f 2 | cut -d\< -f 2 | sort | uniq -d It only assumes that the author prefers the full-name that appears dominantly, by number of contributions. For the purposes of merging, a strictly alphabetical ordering is advised. See MAPPING AUTHORS section of git-shortlog(1) to understand the format of this file. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
…ements I'm close to flipping the switch on hygiene for let-bound identifiers. This commit adds a bunch of support functions for that change... but also a huge amount of cleanup in syntax.rc. The most interesting of these are - the use of TLS for the interners everywhere. We had already breached the "no-global-state" dam by using TLS for encoding, and it saves a lot of code just to use it everywhere. Also, there were many places where two or more interners were passed in attached to different structures, and the danger of having those diverge seemed greater that the danger of having a single one get big and heavy. If the interner size proves to be a problem, it should be quite simple to add a "parameterize"-like dynamic binding form--because we don't have interesting continuation operations (or tail calling, mostly) this should just be a case of a mutation followed by another later mutation. Again, this is only if the interner gets too big. - I renamed the "repr" field of the identifier to "name". I can see the case for "repr" when there's only one field in the structure, but that's no longer the case; there's now a name and a context (both are uints). - the interner now just maps between strings and uints, rather than between idents and uints. The former state made perfect sense when identifiers didn't have syntax contexts, but that's no longer the case. I've run this patch against a fairly recent incoming, and it appears to pass all tests. Let's see if it can be merged....
Handle more characters that appear in types, most notably <>): were missing. Also the new scheme takes care that no two different input strings result in the same mangled string, which was not the case before. Fixes #6921
Handle more characters that appear in types, most notably <>): were missing. Also the new scheme takes care that no two different input strings result in the same mangled string, which was not the case before. Fixes #6921
git log -1 --pretty=format:'%H' is a very convoluted way of saying git rev-parse HEAD. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Oops, you need to send pull requests to |
Sorry, I'll send another one. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
Update changelog for 1.52 I've underestimated the work that goes into this a bit, but it just shows that a lot has happened again in Clippy in 1.52 🙃. [Rendered](https://github.com/xFrednet/rust-clippy/blob/changelog-1-52/CHANGELOG.md) --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.