-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use query to determine whether function needs const checking #69642
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Not sure what's up with the diagnostics changes. I assume that invoking |
Some (I haven't checked all of them) of the additional errors look to me like they would happen if the other errors didn't happen before, so maybe this is just a case of some queries being triggered that would have otherwise not gotten triggered at all because of errors happening before them? |
You can check this by looking at the query stack with |
☔ The latest upstream changes (presumably #68944) made this pull request unmergeable. Please resolve the merge conflicts. |
@ecstatic-morse any updates? also you have a conflict to resolve :) |
313d456
to
eb74096
Compare
@oli-obk I preserved the existing query order by calling |
@bors r+ |
📌 Commit eb74096 has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#69642 (Use query to determine whether function needs const checking) - rust-lang#71239 (Rename `asm` test directory in favor of `llvm_asm`) - rust-lang#71246 (Implement `Clone` for `liballoc::collections::linked_list::Cursor`.) - rust-lang#71247 (Remove unnecessary variable intialization) - rust-lang#71254 (Minor fix and addition to doc comments) Failed merges: r? @ghost
Resolves #69615.
The HIR const-checker was checking the
constness
of a function'sfn_sig
to determine whether a function needed const-checking. Now that const trait impls are a thing, this is no longer enough. All code should use theis_const_fn_raw
query instead, which takes the constness of the impl block into account.r? @oli-obk