Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Clone for liballoc::collections::linked_list::Cursor. #71246

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Implement Clone for liballoc::collections::linked_list::Cursor. #71246

merged 1 commit into from
Apr 17, 2020

Conversation

crlf0710
Copy link
Member

This implements Clone for linked list Cursor. Implementing Copy is also possible here, but i'm not sure whether i should also do it.

r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020
@Amanieu
Copy link
Member

Amanieu commented Apr 17, 2020

I think a Copy implementation would be counterproductive here since we have move_prev and move_next which modify the cursor in-place.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2020

📌 Commit 22e51cd has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2020
@bors
Auto merge of rust-lang#71255 - Dylan-DPC:rollup-u5yl04z, r=Dylan-DPC
ce93331 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#69642 (Use query to determine whether function needs const checking)
 - rust-lang#71239 (Rename `asm` test directory in favor of `llvm_asm`)
 - rust-lang#71246 (Implement `Clone` for `liballoc::collections::linked_list::Cursor`.)
 - rust-lang#71247 (Remove unnecessary variable intialization)
 - rust-lang#71254 (Minor fix and addition to doc comments)

Failed merges:

r? @ghost
@bors bors merged commit 07cb4f4 into rust-lang:master Apr 17, 2020
@crlf0710 crlf0710 deleted the linked_list_cursor branch April 18, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crlf0710 @Amanieu @bors @rust-highfive