Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #72202

Merged
merged 19 commits into from
May 14, 2020
Merged

Rollup of 8 pull requests #72202

merged 19 commits into from
May 14, 2020

Commits on May 5, 2020

  1. Configuration menu
    Copy the full SHA
    3471bc8 View commit details
    Browse the repository at this point in the history
  2. Update src/test/ui/lint/issue-71290-unused-paren-binop.rs

    Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
    mibac138 and lcnr authored May 5, 2020
    Configuration menu
    Copy the full SHA
    717a7a8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b7a928 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Configuration menu
    Copy the full SHA
    e7b0204 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Change WorkProduct::saved_files to an Option.

    Because there is at most one file.
    nnethercote committed May 12, 2020
    Configuration menu
    Copy the full SHA
    98d6254 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d39f5a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Configuration menu
    Copy the full SHA
    5320bd9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f93bc7 View commit details
    Browse the repository at this point in the history
  3. add spans to require_lang_items

    lcnr committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9001a64 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Configuration menu
    Copy the full SHA
    31fbf33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6aa161 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#71910 - mibac138:necessary-paren, r=cuviper

    Fix unused_parens false positive when using binary operations
    
    Fixes rust-lang#71290
    
    r? @cuviper who provided instructions
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    b20b200 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72087 - matthewjasper:regionck-hang, r=niko…

    …matsakis
    
    Fix hang in lexical_region_resolve
    
    Regionck was stuck in a loop where a region value was changing between two equal regions.
    
    Closes rust-lang#72051
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    2e65f7b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72126 - nnethercote:change-WorkProduct-save…

    …d_files, r=alexcrichton
    
    Change `WorkProduct::saved_files` to an `Option`.
    
    Because there is at most one file.
    
    r? @bjorn3
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    96caa25 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72127 - jademcgough:long-error-explanation-…

    …E0228, r=petrochenkov
    
    add long error explanation for E0228
    
    Add long explanation for the E0228 error code
    Part of rust-lang#61137
    
    Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    746b8ca View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#72141 - kornelski:dontsleep, r=joshtriplett

    Warn against thread::sleep in async fn
    
    I've seen `thread::sleep` wrecking havoc in async servers. There's already an [issue for clippy](rust-lang/rust-clippy#4377), but the std docs could warn against it too.
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    d732aef View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#72170 - lcnr:lang_item, r=oli-obk

    use `require_lang_item` over `unwrap`.
    
    Does not yet replace all uses of `lang_items\(\)\.*\.unwrap\(\)`, as there are more
    than I expected 😅
    
    Fixes rust-lang#72099
    
    r? @RalfJung
    
    *edit: The goal of this this PR is to change ICE from missing lang items to a fatal error.*
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    62f1840 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#72191 - GuillaumeGomez:cleanup-e0589, r=Dyl…

    …an-DPC
    
    Clean up E0589 explanation
    
    r? @Dylan-DPC
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    d7f5e56 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#72194 - doctorn:dispatch-from-dyn-ice, r=es…

    …tebank
    
    Don't ICE on missing `Unsize` impl
    
    Previously code of the form
    
    ```rust
    #![feature(unsize, dispatch_from_dyn)]
    
    use std::marker::Unsize;
    use std::ops::DispatchFromDyn;
    
    pub struct Foo<'a, T: ?Sized> {
        _inner: &'a &'a T,
    }
    
    impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
    ```
    
    would generate an ICE due to the missing `Unsize` impl being run through the `suggest_change_mut` suggestion. This PR adds an early exit and a pointer to the appropriate docs regarding `Unsize` instead:
    
    ```
    error[E0277]: the trait bound `&'a T: std::marker::Unsize<&'a U>` is not satisfied
      --> src/test/ui/issues/issue-71036.rs:11:1
       |
    11 | impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<&'a U>` is not implemented for `&'a T`
       |
       = note: all implementations of `Unsize` are provided automatically by the compiler, see <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> for more information
       = note: required because of the requirements on the impl of `std::ops::DispatchFromDyn<&'a &'a U>` for `&'a &'a T`
    
    error: aborting due to previous error
    
    For more information about this error, try `rustc --explain E0277`.
    ```
    
    r? @estebank
    
    Resolves rust-lang#71036
    Dylan-DPC authored May 14, 2020
    Configuration menu
    Copy the full SHA
    7b5bc61 View commit details
    Browse the repository at this point in the history