-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #72202
Rollup of 8 pull requests #72202
Commits on May 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3471bc8 - Browse repository at this point
Copy the full SHA 3471bc8View commit details -
Update src/test/ui/lint/issue-71290-unused-paren-binop.rs
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
Configuration menu - View commit details
-
Copy full SHA for 717a7a8 - Browse repository at this point
Copy the full SHA 717a7a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b7a928 - Browse repository at this point
Copy the full SHA 4b7a928View commit details
Commits on May 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e7b0204 - Browse repository at this point
Copy the full SHA e7b0204View commit details
Commits on May 12, 2020
-
Change
WorkProduct::saved_files
to anOption
.Because there is at most one file.
Configuration menu - View commit details
-
Copy full SHA for 98d6254 - Browse repository at this point
Copy the full SHA 98d6254View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d39f5a - Browse repository at this point
Copy the full SHA 2d39f5aView commit details
Commits on May 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5320bd9 - Browse repository at this point
Copy the full SHA 5320bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f93bc7 - Browse repository at this point
Copy the full SHA 5f93bc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9001a64 - Browse repository at this point
Copy the full SHA 9001a64View commit details
Commits on May 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 31fbf33 - Browse repository at this point
Copy the full SHA 31fbf33View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6aa161 - Browse repository at this point
Copy the full SHA f6aa161View commit details -
Rollup merge of rust-lang#71910 - mibac138:necessary-paren, r=cuviper
Fix unused_parens false positive when using binary operations Fixes rust-lang#71290 r? @cuviper who provided instructions
Configuration menu - View commit details
-
Copy full SHA for b20b200 - Browse repository at this point
Copy the full SHA b20b200View commit details -
Rollup merge of rust-lang#72087 - matthewjasper:regionck-hang, r=niko…
…matsakis Fix hang in lexical_region_resolve Regionck was stuck in a loop where a region value was changing between two equal regions. Closes rust-lang#72051
Configuration menu - View commit details
-
Copy full SHA for 2e65f7b - Browse repository at this point
Copy the full SHA 2e65f7bView commit details -
Rollup merge of rust-lang#72126 - nnethercote:change-WorkProduct-save…
…d_files, r=alexcrichton Change `WorkProduct::saved_files` to an `Option`. Because there is at most one file. r? @bjorn3
Configuration menu - View commit details
-
Copy full SHA for 96caa25 - Browse repository at this point
Copy the full SHA 96caa25View commit details -
Rollup merge of rust-lang#72127 - jademcgough:long-error-explanation-…
…E0228, r=petrochenkov add long error explanation for E0228 Add long explanation for the E0228 error code Part of rust-lang#61137 Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
Configuration menu - View commit details
-
Copy full SHA for 746b8ca - Browse repository at this point
Copy the full SHA 746b8caView commit details -
Rollup merge of rust-lang#72141 - kornelski:dontsleep, r=joshtriplett
Warn against thread::sleep in async fn I've seen `thread::sleep` wrecking havoc in async servers. There's already an [issue for clippy](rust-lang/rust-clippy#4377), but the std docs could warn against it too.
Configuration menu - View commit details
-
Copy full SHA for d732aef - Browse repository at this point
Copy the full SHA d732aefView commit details -
Rollup merge of rust-lang#72170 - lcnr:lang_item, r=oli-obk
use `require_lang_item` over `unwrap`. Does not yet replace all uses of `lang_items\(\)\.*\.unwrap\(\)`, as there are more than I expected 😅 Fixes rust-lang#72099 r? @RalfJung *edit: The goal of this this PR is to change ICE from missing lang items to a fatal error.*
Configuration menu - View commit details
-
Copy full SHA for 62f1840 - Browse repository at this point
Copy the full SHA 62f1840View commit details -
Rollup merge of rust-lang#72191 - GuillaumeGomez:cleanup-e0589, r=Dyl…
…an-DPC Clean up E0589 explanation r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for d7f5e56 - Browse repository at this point
Copy the full SHA d7f5e56View commit details -
Rollup merge of rust-lang#72194 - doctorn:dispatch-from-dyn-ice, r=es…
…tebank Don't ICE on missing `Unsize` impl Previously code of the form ```rust #![feature(unsize, dispatch_from_dyn)] use std::marker::Unsize; use std::ops::DispatchFromDyn; pub struct Foo<'a, T: ?Sized> { _inner: &'a &'a T, } impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {} ``` would generate an ICE due to the missing `Unsize` impl being run through the `suggest_change_mut` suggestion. This PR adds an early exit and a pointer to the appropriate docs regarding `Unsize` instead: ``` error[E0277]: the trait bound `&'a T: std::marker::Unsize<&'a U>` is not satisfied --> src/test/ui/issues/issue-71036.rs:11:1 | 11 | impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<&'a U>` is not implemented for `&'a T` | = note: all implementations of `Unsize` are provided automatically by the compiler, see <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> for more information = note: required because of the requirements on the impl of `std::ops::DispatchFromDyn<&'a &'a U>` for `&'a &'a T` error: aborting due to previous error For more information about this error, try `rustc --explain E0277`. ``` r? @estebank Resolves rust-lang#71036
Configuration menu - View commit details
-
Copy full SHA for 7b5bc61 - Browse repository at this point
Copy the full SHA 7b5bc61View commit details