Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #73599

Closed
wants to merge 26 commits into from

Commits on Jun 18, 2020

  1. Configuration menu
    Copy the full SHA
    1d08b1b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Squashed all commits

    rakshith-ravi committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    0624a5a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc60282 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4896a06 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Fix typos in doc comments

    This commit fixes typos in the doc comments of 'librustc_mir/monomorphize/collector.rs'
    JOE1994 committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    6374054 View commit details
    Browse the repository at this point in the history
  2. Fix typo in error_codes doc

    dario23 committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    e3d735d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c74ab4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    467415d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a657be4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    726b6f4 View commit details
    Browse the repository at this point in the history
  7. Update UI tests

    GuillaumeGomez committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    c14d85f View commit details
    Browse the repository at this point in the history
  8. Update src/librustc_mir/monomorphize/collector.rs

    typo fix
    
    Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
    JOE1994 and jonas-schievink committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    893077c View commit details
    Browse the repository at this point in the history
  9. Prefer accessible paths in 'use' suggestions

    This fixes an issue with the following sample:
    
        mod foo {
    	mod inaccessible {
    	    pub struct X;
    	}
    	pub mod avail {
    	    pub struct X;
    	}
        }
    
        fn main() { X; }
    
    Instead of suggesting both `use crate::foo::inaccessible::X;` and `use
    crate::foo::avail::X;`, it should only suggest the latter.
    
    It is done by trimming the list of suggestions from inaccessible paths
    if accessible paths are present.
    
    Visibility is checked with `is_accessible_from` now instead of being
    hard-coded.
    
    -
    
    Some tests fixes are trivial, and others require a bit more explaining,
    here are my comments:
    
    src/test/ui/issues/issue-35675.stderr: Only needs to make the enum
    public to have the suggestion make sense.
    
    src/test/ui/issues/issue-42944.stderr: Importing the tuple struct won't
    help because its constructor is not visible, so the attempted
    constructor does not work. In that case, it's better not to suggest it.
    The case where the constructor is public is covered in `issue-26545.rs`.
    da-x committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    fea5ab1 View commit details
    Browse the repository at this point in the history
  10. Revert "Rollup merge of rust-lang#72389 - Aaron1011:feature/move-fn-s…

    …elf-msg, r=nikomatsakis"
    
    This reverts commit 372cb9b, reversing
    changes made to 5c61a8d.
    Aaron1011 committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    20866c5 View commit details
    Browse the repository at this point in the history
  11. Re-enable Clippy tests

    Aaron1011 committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    2959352 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

    impl PartialEq<Vec<B>> for &[A], &mut [A]
    
    rust-lang/rfcs#2917
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    c062ce5 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#72271 - rakshith-ravi:master, r=varkor

    Improve compiler error message for wrong generic parameter order
    
    - Added optional "help" parameter that shows a help message on the compiler error if required.
    - Added a simple ordered parameter as a sample help.
    
    @varkor will make more changes as required. Let me know if I'm heading in the right direction.
    
    Fixes rust-lang#68437
    
    r? @varkor
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    103b0e3 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#72623 - da-x:use-suggest-public-path, r=pet…

    …rochenkov
    
    Prefer accessible paths in 'use' suggestions
    
    This PR addresses issue rust-lang#26454, where `use` suggestions are made for paths that don't work. For example:
    
    ```rust
    mod foo {
        mod bar {
            struct X;
        }
    }
    
    fn main() { X; } // suggests `use foo::bar::X;`
    ```
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    fcea8a1 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#73472 - GuillaumeGomez:cleanup-e0689, r=Dyl…

    …an-DPC
    
    Clean up E0689 explanation
    
    r? @Dylan-DPC
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    c1ca2d6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7f687b9 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#73572 - JOE1994:patch-4, r=jonas-schievink

    Fix typos in doc comments
    
    Hello 🦀 ,
    
    This commit fixes typos in the doc comments of 'librustc_mir/monomorphize/collector.rs'
    
    Thank you for reviewing this PR 👍
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    e78a0b3 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#73575 - dario23:typo-errorcodes-doc, r=matt…

    …hewjasper
    
    Fix typo in error_codes doc
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    fd4558e View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#73578 - RalfJung:ty-ctxt-at, r=jonas-schievink

    Make is_freeze and is_copy_modulo_regions take TyCtxtAt
    
    Make is_freeze and is_copy_modulo_regions take TyCtxtAt instead of separately taking TyCtxt and Span. This is consistent with is_sized.
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    cd7cc60 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…

    …from, r=Amanieu
    
    deprecate wrapping_offset_from
    
    As per rust-lang#41079 (comment) which seems like a consensus.
    
    r? @Amanieu
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    8db431e View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#73582 - RalfJung:miri-span-bug, r=oli-obk

    Miri: replace many bug! by span_bug!
    
    r? @oli-obk
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    02efde0 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#73594 - Aaron1011:revert/move-fn-self-msg, …

    …r=petrochenkov
    
    Revert PR rust-lang#72389 - "Explain move errors that occur due to method calls involving `self"
    
    r? @petrochenkov
    Manishearth committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    8cabd20 View commit details
    Browse the repository at this point in the history