-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #75060
Rollup of 10 pull requests #75060
Conversation
This removes all dependencies on pre-1.0 proc-macro ecosystem crates (syn, quote, and proc-macro2)
…st_passes, librustc_ast_pretty
These are quite long, usually, and in most cases not interesting. On smaller terminals they can take up more than a full page of output, hiding the error diagnostics emitted.
…ulacrum BTreeMap: remove into_slices and its unsafe block A small tweak to make BTreeMap code shorter and less unsafe. r? @Mark-Simulacrum
…tracking, r=Mark-Simulacrum BTreeMap::drain_filter should not touch the root during iteration Although Miri doesn't point it out, I believe there is undefined behaviour using `drain_filter` when draining the 11th-last element from a tree that was larger. When this happens, the last remaining child nodes are merged, the root becomes empty and is popped from the tree. That last step establishes a mutable reference to the node elected root and writes a pointer in `node::Root`, while iteration continues to visit the same node. This is mostly code from rust-lang#74437, slightly adapted.
Clean up E0733 explanation r? @Dylan-DPC
…ulacrum BTreeMap: define forget_type only when relevant Similar to `forget_node_type` for handles. No effect on generated code, apart maybe from the superfluous calls that might not have been optimized away. r? @Mark-Simulacrum
Make tests faster in Miri Reduce some test iteration counts in Miri.
…r=Mark-Simulacrum Update elasticlunr-rs and ammonia transitive deps This removes all dependencies on pre-1.0 proc-macro ecosystem crates (syn, quote, and proc-macro2)
…th-tracing, r=oli-obk Replaced log with tracing crate Issue rust-lang#74747
…kfire Clean up E0744 explanation r? @Dylan-DPC
…nkov Rename rustc_middle::cstore::DepKind to CrateDepKind It is ambiguous with DepGraph's own DepKind.
…=alexcrichton Avoid dumping rustc invocations to stdout These are quite long, usually, and in most cases not interesting. On smaller terminals they can take up more than a full page of output, hiding the error diagnostics emitted.
📌 Commit 50f2b5d has been approved by |
☀️ Test successful - checks-actions, checks-azure |
This was a slight performance regression, of up to 1%. Perhaps one of the BTree PRs are at fault? I recall there being some known regressions there. |
Hmm, I'm not familiar with that, cc @ssomers in case. |
#74762 is the only one that shows a penalty, benchmarking with stage 0. I.e.
They're mostly benchmarks that keep changing their tune up and down whenever you touch some code, except the |
@ssomers Thanks for investigating it! @Mark-Simulacrum Is it worth to revert it and check perf run? |
#75182 may be a better thing to check the perf of |
Successful merges:
Failed merges:
r? @ghost