Add keyboard handling to the theme picker menu #78584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly motivated by docs.rs. It's really weird when arrow keys work in the top dropdown menu, but don't work in other dropdown menus on the same page.
|
Some changes occurred in HTML/CSS/JS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Most of the code in mod.rs should be code that really needs to have the list of available themes inlined into it.
GuillaumeGomez
approved these changes
Nov 4, 2020
|
Tested locally and it's really great! Thanks! @bors: r+ rollup |
|
📌 Commit 17b8ca9 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 5, 2020
Add keyboard handling to the theme picker menu This PR is mostly designed to bring the theme picker closer to feature parity with the menu bar from docs.rs. Though the rustdoc theme picker is technically already usable from the keyboard, it's really weird that arrow keys work on some of the menus, but not all of them, in the exact same page.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 5, 2020
Add keyboard handling to the theme picker menu This PR is mostly designed to bring the theme picker closer to feature parity with the menu bar from docs.rs. Though the rustdoc theme picker is technically already usable from the keyboard, it's really weird that arrow keys work on some of the menus, but not all of them, in the exact same page.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 5, 2020
Add keyboard handling to the theme picker menu This PR is mostly designed to bring the theme picker closer to feature parity with the menu bar from docs.rs. Though the rustdoc theme picker is technically already usable from the keyboard, it's really weird that arrow keys work on some of the menus, but not all of them, in the exact same page.
This was referenced Nov 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#76718 (Move Vec UI tests to unit tests when possible) - rust-lang#78093 (Clean up docs for 'as' keyword) - rust-lang#78425 (Move f64::NAN ui tests into `library`) - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs) - rust-lang#78584 (Add keyboard handling to the theme picker menu) - rust-lang#78716 (Array trait impl comment/doc fixes) - rust-lang#78727 ((rustdoc) fix test for trait impl display) - rust-lang#78733 (fix a couple of clippy warnings:) - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe)) - rust-lang#78738 (Move range in ui test to ops test in library/core) - rust-lang#78739 (Fix ICE on type error in async function) - rust-lang#78742 (make intern_const_alloc_recursive return error) - rust-lang#78756 (Update cargo) - rust-lang#78757 (Improve and clean up some intra-doc links) - rust-lang#78758 (Fixed typo in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
jyn514
added
C-enhancement
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2020
…t, r=jyn514 Add shortcut for theme picker menu Follow-up of rust-lang#78584 Just like you can focus the search input by pressing "S", you can now access the theme picker menu by pressing "T" and navigate through the options only using the keyboard. cc `@notriddle` r? `@jyn514`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2020
… r=jyn514 Add shortcut for theme picker menu Follow-up of rust-lang#78584 Just like you can focus the search input by pressing "S", you can now access the theme picker menu by pressing "T" and navigate through the options only using the keyboard. cc `@notriddle` r? `@jyn514`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly designed to bring the theme picker closer to feature parity with the menu bar from docs.rs. Though the rustdoc theme picker is technically already usable from the keyboard, it's really weird that arrow keys work on some of the menus, but not all of them, in the exact same page.