Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE on type error in async function #78739

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Fix ICE on type error in async function #78739

merged 1 commit into from
Nov 5, 2020

Conversation

hameerabbasi
Copy link
Contributor

@hameerabbasi hameerabbasi commented Nov 4, 2020 •
edited by JohnTitor
Loading

Fixes #78654

@hameerabbasi
Copy link
Contributor Author

r? @nikomatsakis

@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 4, 2020
@jyn514 jyn514 changed the title Fix issue 78654. Fix ICE on type error in async function Nov 4, 2020
@jyn514 jyn514 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2020
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2020

📌 Commit a70e0c2 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 5, 2020
@m-ou-se
Rollup merge of rust-lang#78739 - hameerabbasi:issue-78654, r=nikomat…
7e51236 
…sakis

Fix ICE on type error in async function

Fixes rust-lang#78654
This was referenced Nov 5, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2020
@bors
Auto merge of rust-lang#78767 - m-ou-se:rollup-eu5wgxl, r=m-ou-se
f7801d6 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#76718 (Move Vec UI tests to unit tests when possible)
 - rust-lang#78093 (Clean up docs for 'as' keyword)
 - rust-lang#78425 (Move f64::NAN ui tests into `library`)
 - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs)
 - rust-lang#78584 (Add keyboard handling to the theme picker menu)
 - rust-lang#78716 (Array trait impl comment/doc fixes)
 - rust-lang#78727 ((rustdoc) fix test for trait impl display)
 - rust-lang#78733 (fix a couple of clippy warnings:)
 - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe))
 - rust-lang#78738 (Move range in ui test to ops test in library/core)
 - rust-lang#78739 (Fix ICE on type error in async function)
 - rust-lang#78742 (make intern_const_alloc_recursive return error)
 - rust-lang#78756 (Update cargo)
 - rust-lang#78757 (Improve and clean up some intra-doc links)
 - rust-lang#78758 (Fixed typo in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 171d29c into rust-lang:master Nov 5, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 5, 2020
@hameerabbasi hameerabbasi deleted the issue-78654 branch November 5, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
5 participants
@hameerabbasi @nikomatsakis @bors @jyn514 @rustbot