Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the message for if_let_guard feature gate #80121

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

if-let guards are now implemented by #79051 🎉
Thanks @camelid for pointing this out 🙂

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@LeSeulArtichaut LeSeulArtichaut added C-cleanup Category: PRs that clean code up or issues documenting cleanup. F-if_let_guard `#![feature(if_let_guard)]` labels Dec 17, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 17, 2020

📌 Commit 46e9212 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2020
@LeSeulArtichaut
Copy link
Contributor Author

(Should this be rollup=always?)

@davidtwco
Copy link
Member

@bors rollup=always

RalfJung added a commit to RalfJung/rust that referenced this pull request Dec 18, 2020
…, r=davidtwco

Change the message for `if_let_guard` feature gate

`if-let` guards are now implemented by rust-lang#79051 🎉
Thanks `@camelid` for pointing this out 🙂
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#80121 (Change the message for `if_let_guard` feature gate)
 - rust-lang#80130 (docs: Edit rustc_span::symbol::Symbol method)
 - rust-lang#80135 (Don't allow `const` to begin a nonterminal)
 - rust-lang#80145 (Fix typo in rustc_typeck docs)
 - rust-lang#80146 (Edit formatting in Rust Prelude docs)
 - rust-lang#80147 (Add missing punctuation to std::alloc docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea6cc5a into rust-lang:master Dec 18, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 18, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the if-let-experimental branch December 18, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. F-if_let_guard `#![feature(if_let_guard)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants