-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the message for if_let_guard
feature gate
#80121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 17, 2020
LeSeulArtichaut
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
F-if_let_guard
`#![feature(if_let_guard)]`
labels
Dec 17, 2020
davidtwco
approved these changes
Dec 17, 2020
@bors r+ |
📌 Commit 46e9212 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 17, 2020
(Should this be rollup=always?) |
@bors rollup=always |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Dec 18, 2020
…, r=davidtwco Change the message for `if_let_guard` feature gate `if-let` guards are now implemented by rust-lang#79051 🎉 Thanks `@camelid` for pointing this out 🙂
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#80121 (Change the message for `if_let_guard` feature gate) - rust-lang#80130 (docs: Edit rustc_span::symbol::Symbol method) - rust-lang#80135 (Don't allow `const` to begin a nonterminal) - rust-lang#80145 (Fix typo in rustc_typeck docs) - rust-lang#80146 (Edit formatting in Rust Prelude docs) - rust-lang#80147 (Add missing punctuation to std::alloc docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
F-if_let_guard
`#![feature(if_let_guard)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if-let
guards are now implemented by #79051 🎉Thanks @camelid for pointing this out 🙂