-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #80153
Closed
Closed
Rollup of 7 pull requests #80153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit wording of the doc comment for rustc_span::symbol::Symbol::can_be_raw to match related methods.
Thanks to Vadim Petrochenkov who [told me what the fix was][z]! [z]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/finding.20which.20macro.20rule.20to.20use/near/220240422
Use consistent punctuation and capitalization in the list of things re-exported in the prelude. Also adds a (possibly missing) word.
Add a period to first line of module docs to match other modules in std.
…, r=davidtwco Change the message for `if_let_guard` feature gate `if-let` guards are now implemented by rust-lang#79051 🎉 Thanks `@camelid` for pointing this out 🙂
…, r=RalfJung Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop" This fixes rust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
docs: Edit rustc_span::symbol::Symbol method Edit wording of the doc comment for [rustc_span::symbol::Symbol::can_be_raw](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_span/symbol/struct.Symbol.html#method.can_be_raw) to match related methods.
Don't allow `const` to begin a nonterminal Fixes rust-lang#79908. Thanks to Vadim Petrochenkov who [told me what the fix was][z]! [z]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/finding.20which.20macro.20rule.20to.20use/near/220240422 r? `@petrochenkov`
Fix typo in rustc_typeck docs
… r=lcnr Edit formatting in Rust Prelude docs Use consistent punctuation and capitalization in the list of things re-exported in the prelude. Also adds a (possibly missing) word.
Add missing punctuation to std::alloc docs Add a period to first line of module docs to match other modules in std.
@bors r+ rollup=never p=7 |
📌 Commit 3c6140c has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Dec 18, 2020
⌛ Testing commit 3c6140c with merge d187726e828d27c19b7ad58f6ace7db1f7a7086e... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Dec 18, 2020
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
if_let_guard
feature gate #80121 (Change the message forif_let_guard
feature gate)const
to begin a nonterminal #80135 (Don't allowconst
to begin a nonterminal)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup