const_evaluatable_checked: Stop eagerly erroring in is_const_evaluatable
#82707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Mar 2, 2021
lcnr
added
A-const-generics
oli-obk
requested changes
Mar 3, 2021
src/test/ui/const-generics/const_evaluatable_checked/cross_crate_predicate.stderr
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
r? @oli-obk |
|
@bors r+ |
|
📌 Commit 8e353bb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#82707 (const_evaluatable_checked: Stop eagerly erroring in `is_const_evaluatable`) - rust-lang#83040 (extract `ConstKind::Unevaluated` into a struct) - rust-lang#83280 (Fix pluralization in keyword docs) - rust-lang#83289 (Move some tests to more reasonable directories - 5) - rust-lang#83306 (Extend `proc_macro_back_compat` lint to `js-sys`) - rust-lang#83327 (Extend comment in `UsedLocals::visit_lhs`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82279
We don't want to be emitting errors inside of is_const_evaluatable because we may call this during selection where it should be able to fail silently
There were two errors being emitted in
is_const_evaluatable. The one causing the compile error in #82279 was inside the match arm forFailureKind::MentionsParambut I moved the other error being emitted too since it made things cleaner imoThe
NotConstEvaluatableenum *should* have a fourth variant for when we fail to evaluate a concrete const, e.g.0 - 1but that cant happen until #81339cc @oli-obk @lcnr
r? @nikomatsakis