Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pluralization in keyword docs #83280

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Fix pluralization in keyword docs #83280

merged 2 commits into from
Mar 21, 2021

Conversation

starthal
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2021
dtolnay
dtolnay approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Mar 18, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 18, 2021

📌 Commit b6a12d5 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dtolnay
Copy link
Member

dtolnay commented Mar 18, 2021

^ a reference to [closure] earlier in the same documentation block is broken

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2021
@starthal starthal force-pushed the fix-typo-keyword-docs branch from b6a12d5 to 5c5c108 Compare March 20, 2021 03:02
@starthal starthal force-pushed the fix-typo-keyword-docs branch from 5c5c108 to 3855597 Compare March 20, 2021 04:44
@Dylan-DPC-zz
Copy link

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented Mar 20, 2021

📌 Commit 3855597 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 21, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2021
@bors
Auto merge of rust-lang#83333 - Dylan-DPC:rollup-0rdt6sz, r=Dylan-DPC
bbf07c0 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#82707 (const_evaluatable_checked: Stop eagerly erroring in `is_const_evaluatable`)
 - rust-lang#83040 (extract `ConstKind::Unevaluated` into a struct)
 - rust-lang#83280 (Fix pluralization in keyword docs)
 - rust-lang#83289 (Move some tests to more reasonable directories - 5)
 - rust-lang#83306 (Extend `proc_macro_back_compat` lint to `js-sys`)
 - rust-lang#83327 (Extend comment in `UsedLocals::visit_lhs`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0fa6831 into rust-lang:master Mar 21, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
7 participants
@starthal @rust-highfive @dtolnay @bors @rust-log-analyzer @Dylan-DPC-zz @rustbot