Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #82896

Merged
merged 37 commits into from
Mar 8, 2021
Merged

Rollup of 10 pull requests #82896

merged 37 commits into from
Mar 8, 2021

Commits on Feb 13, 2021

  1. Configuration menu
    Copy the full SHA
    6a679ff View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Fix jemalloc usage on OSX

    sfackler committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    6e52b23 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    920e2d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Refactor confirm_builtin_call, remove partial if

    Pass callee expr to `confirm_builtin_call`. This removes a partial
    pattern match in `confirm_builtin_call` and the `panic` in the `else`
    branch. The diff is large because of indentation changes caused by
    removing the if-let.
    osa1 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    c8a0e8d View commit details
    Browse the repository at this point in the history
  2. expand: Remove obsolete DirectoryOwnership::UnownedViaMod

    This ownership kind is only constructed in the case of path attributes like `#[path = ".."]` without a file name segment, which always represent some kind of directories and will produce and error on attempt to parse them as a module file.
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    bc18eb4 View commit details
    Browse the repository at this point in the history
  3. expand: Move module file path stack from global session to expansion …

    …data
    
    Also don't push the paths on the stack directly in `fn parse_external_mod`, return them instead.
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    39052c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bdf81d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3d0b622 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    46b67aa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    da3419e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    29a9ef2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1e1d574 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1fe2eb8 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    1b4860a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Configuration menu
    Copy the full SHA
    6f49aad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    069e612 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5dad6c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cf52469 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca48d15 View commit details
    Browse the repository at this point in the history
  6. Move tests to own file

    CraftSpider committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    83cece4 View commit details
    Browse the repository at this point in the history
  7. x.py fmt

    CraftSpider committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    70c9b37 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    18841ec View commit details
    Browse the repository at this point in the history
  9. Move full configuration logic from rustc_expand to `rustc_builtin_m…

    …acros`
    
    This logic is applicable to two specific macros and not to the expansion infrastructure in general.
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    f9019b7 View commit details
    Browse the repository at this point in the history
  10. cfg_eval: Configure everything through mutable visitor methods

    This is simpler and mirrors what invocation collector does
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    10ed08f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5d27728 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Edit ructc_ast_lowering docs

    Fixes some punctuation and formatting; also makes some small wording changes.
    pierwill committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    6b2eb0e View commit details
    Browse the repository at this point in the history
  2. Generalize Write impl for Vec<u8> to Vec<u8, A>

    As discussed in the issue tracker for the wg-allocators working group[1], updating this implementation for allocator support was most likely just forgotten in the original PR.
    
    [1]: rust-lang/wg-allocators#86
    athre0z committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    ab8995b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Rollup merge of rust-lang#82047 - the8472:fast-rename, r=davidtwco

    bypass auto_da_alloc for metadata files
    
    This saves about 0.7% when rerunning the UI test suite. I.e. when the metadata files exist and will be overwritten. No improvements expected for a clean build. So it might show up in incr-patched perf results.
    ```
    regular rename:
    
    Benchmark rust-lang#1: touch src/tools/compiletest/src/main.rs ; RUSTC_WRAPPER="" schedtool -B -e ./x.py test src/test/ui
      Time (mean ± σ):     47.305 s ±  0.170 s    [User: 1631.540 s, System: 412.648 s]
      Range (min … max):   47.125 s … 47.856 s    20 runs
    
    non-durable rename:
    
    Benchmark rust-lang#1: touch src/tools/compiletest/src/main.rs ; RUSTC_WRAPPER="" schedtool -B -e ./x.py test src/test/ui
      Time (mean ± σ):     46.930 s ±  0.064 s    [User: 1634.344 s, System: 396.038 s]
      Range (min … max):   46.759 s … 47.043 s    20 runs
    ```
    
    There are more places that trigger auto_da_alloc behavior by overwriting existing files with O_TRUNC, but those are much harder to locate because `O_TRUNC` is set on `open()` but the writeback is triggered on `close()`. The latter is the part which shows up in profiles.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    da74a77 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#82415 - petrochenkov:modin3, r=davidtwco

    expand: Refactor module loading
    
    This is an accompanying PR to rust-lang#82399, but they can be landed independently.
    See individual commits for more details.
    
    Anyone should be able to review this equally well because all people actually familiar with this code left the project.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4a4e3e6 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#82557 - rylev:natvis-improvements, r=varkor

    Add natvis for Result, NonNull, CString, CStr, and Cow
    
    This adds natvis support (used for Windows debugging) to the following types: `Result`, `NonNull`, `CString`, `CStr`, and `Cow`.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    298c31b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#82613 - CraftSpider:fix-de, r=aDotInTheVoid

    Remove Item::kind, use tagged enum. Rename variants to match
    
    Fixes rust-lang#82299, by making the ItemEnum tagged. Doesn't remove ItemKind as it's still used in other places.
    
    r? `````@jyn514`````
    `````@rustbot````` label: +A-rustdoc-json +T-rustdoc
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0681951 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix

    Fix jemalloc usage on OSX
    
    Closes rust-lang#82423
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7b78d86 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#82682 - petrochenkov:cfgeval, r=Aaron1011

    Implement built-in attribute macro `#[cfg_eval]` + some refactoring
    
    This PR implements a built-in attribute macro `#[cfg_eval]` as it was suggested in rust-lang#79078 to avoid `#[derive()]` without arguments being abused as a way to configure input for other attributes.
    
    The macro is used for eagerly expanding all `#[cfg]` and `#[cfg_attr]` attributes in its input ("fully configuring" the input).
    The effect is identical to effect of `#[derive(Foo, Bar)]` which also fully configures its input before passing it to macros `Foo` and `Bar`, but unlike `#[derive]` `#[cfg_eval]` can be applied to any syntax nodes supporting macro attributes, not only certain items.
    
    `cfg_eval` was the first name suggested in rust-lang#79078, but other alternatives are also possible, e.g. `cfg_expand`.
    
    ```rust
    #[cfg_eval]
    #[my_attr] // Receives `struct S {}` as input, the field is configured away by `#[cfg_eval]`
    struct S {
        #[cfg(FALSE)]
        field: u8,
    }
    ```
    
    Tracking issue: rust-lang#82679
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9c31057 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#82684 - tmiasko:dest-prop, r=jonas-schievink

    Disable destination propagation on all mir-opt-levels
    
    The new `// compile-flags: -Zunsound-mir-opts` are inserted without an extra newline to avoid introducing a large mir-opt diff.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    dd7a606 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#82755 - osa1:confirm_builtin_call_refactor,…

    … r=petrochenkov
    
    Refactor confirm_builtin_call, remove partial if
    
    Pass callee expr to `confirm_builtin_call`. This removes a partial
    pattern match in `confirm_builtin_call` and the `panic` in the `else`
    branch. The diff is large because of indentation changes caused by
    removing the if-let.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    041bc04 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#82857 - pierwill:edit-ast-lowering-lib, r=D…

    …ylan-DPC
    
    Edit ructc_ast_lowering docs
    
    Fixes some punctuation and formatting; also makes some small wording changes.
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    08475e7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …

    …r=TimDiekmann
    
    Generalize Write impl for Vec<u8> to Vec<u8, A>
    
    As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.
    
    r? `````@TimDiekmann`````
    
    [1]: rust-lang/wg-allocators#86
    Dylan-DPC authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3b0a02a View commit details
    Browse the repository at this point in the history