Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/replace some outdated crates from the dependency tree #83239

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Remove/replace some outdated crates from the dependency tree #83239

merged 2 commits into from
Mar 27, 2021

Conversation

JohnTitor
Copy link
Member

  • Remove cloudabi by updating parking_lot to 0.11.1.
  • Replace packed_simd with packed_simd2 by updating bytecount to 0.6.2.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnTitor
cargo update -p parking_lot -p parking_lot_core
79348f4 
Changelog: https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md#parking_lot_core-083-2021-02-12
The full log:
```
Removing cloudabi v0.1.0
Updating parking_lot v0.11.0 -> v0.11.1
Updating parking_lot_core v0.8.0 -> v0.8.3
```
@JohnTitor
cargo update -p bytecount
2b0e27e 
Commit range: llogiq/bytecount@b0f5fba...8dcd437

The full log:
```
Updating bytecount v0.6.0 -> v0.6.2
Adding libm v0.1.4
Removing packed_simd v0.3.3
Adding packed_simd_2 v0.3.4
```
@joshtriplett
Copy link
Member

Seems reasonable. Note that this also pulls in the libm crate. That seems fine though.

@Mark-Simulacrum
Copy link
Member

Hm, something seems wrong with the tidy logic - libm is new (AFAICT) but not listed in the tidy dep filter. @JohnTitor would you be up for investigating that? I'd expect that it would need to get added, but maybe I'm missing something...

@JohnTitor
Copy link
Member Author

Hm, something seems wrong with the tidy logic - libm is new (AFAICT) but not listed in the tidy dep filter. @JohnTitor would you be up for investigating that? I'd expect that it would need to get added, but maybe I'm missing something...

Seems we don't check the deps on submodules/subtrees, the tree looks like: rustfmt-nightly -> bytecount -> packed_simd2 -> libm. For another example, derive-new, which is a direct dep on clippy, isn't also catched. Is this desired?

@Mark-Simulacrum
Copy link
Member

I definitely think we need to be checking those dependencies. However, I don't think we need to block this PR on that; let's file an issue (or even better, a PR if you'd be willing) to expand the checks to include submodule roots. It'll likely be desirable to indicate whether the dependency is in the compiler or in a tool, though.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2021

📌 Commit 2b0e27e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#83239 - JohnTitor:reduce-deps, r=Mark-Simul…
91c019e 
…acrum

Remove/replace some outdated crates from the dependency tree

- Remove `cloudabi` by updating `parking_lot` to 0.11.1.
- Replace `packed_simd` with `packed_simd2` by updating `bytecount` to 0.6.2.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 26, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 27, 2021
@JohnTitor
Rollup merge of rust-lang#83239 - JohnTitor:reduce-deps, r=Mark-Simul…
929e88a 
…acrum

Remove/replace some outdated crates from the dependency tree

- Remove `cloudabi` by updating `parking_lot` to 0.11.1.
- Replace `packed_simd` with `packed_simd2` by updating `bytecount` to 0.6.2.
@JohnTitor JohnTitor mentioned this pull request Mar 27, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Mar 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2021
@bors
Auto merge of rust-lang#83547 - JohnTitor:rollup-qh7j6hg, r=JohnTitor
feaac19 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#83239 (Remove/replace some outdated crates from the dependency tree)
 - rust-lang#83328 (Fixes to inline assmebly tests)
 - rust-lang#83343 (Simplify and fix byte skipping in format! string parser)
 - rust-lang#83388 (Make # pretty print format easier to discover)
 - rust-lang#83431 (Tell GitHub to highlight `config.toml.example` as TOML)
 - rust-lang#83508 (Use the direct link to the platform support page)
 - rust-lang#83511 (compiletest: handle llvm_version with suffix like "12.0.0libcxx")
 - rust-lang#83524 (Document that the SocketAddr memory representation is not stable)
 - rust-lang#83525 (fix doc comment for `ty::Dynamic`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5473b6d into rust-lang:master Mar 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 27, 2021
@JohnTitor JohnTitor deleted the reduce-deps branch March 27, 2021 10:53
@JohnTitor JohnTitor mentioned this pull request Mar 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
7 participants
@JohnTitor @rust-highfive @rust-log-analyzer @joshtriplett @Mark-Simulacrum @bors @rustbot