Tell GitHub to highlight config.toml.example as TOML
#83431
Conversation
This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
camelid
added
the
A-meta
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I wish we could just rename it to config.example.toml - @Mark-Simulacrum do you think that would break too many scripts? Maybe we could make config.toml.example a symlink somehow? |
|
Hm, seeing as we don't expect people to edit it directly really, why do you think such a change is a good idea? It does have some churn cost and doesn't seem particularly meaningful to humans? I'm inclined to just approve this PR (which seems like a small win). |
|
This PR doesn't fix it for editing with vim or other editors I think.
Sure, this is definitely a strict improvement - I just think it would be nice to make the fix more general. I'm sympathetic to not wanting churn though. |
|
i still prefer config.toml.example rather than config.example.toml because:
|
|
@bors r+ rollup |
|
📌 Commit b3ae90b has been approved by |
bors
added
S-waiting-on-bors
…s, r=Mark-Simulacrum Tell GitHub to highlight `config.toml.example` as TOML This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
…s, r=Mark-Simulacrum Tell GitHub to highlight `config.toml.example` as TOML This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
Rollup of 9 pull requests Successful merges: - rust-lang#83239 (Remove/replace some outdated crates from the dependency tree) - rust-lang#83328 (Fixes to inline assmebly tests) - rust-lang#83343 (Simplify and fix byte skipping in format! string parser) - rust-lang#83388 (Make # pretty print format easier to discover) - rust-lang#83431 (Tell GitHub to highlight `config.toml.example` as TOML) - rust-lang#83508 (Use the direct link to the platform support page) - rust-lang#83511 (compiletest: handle llvm_version with suffix like "12.0.0libcxx") - rust-lang#83524 (Document that the SocketAddr memory representation is not stable) - rust-lang#83525 (fix doc comment for `ty::Dynamic`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This should be a nice small quality of life improvement when looking at
config.toml.exampleon GitHub or looking at diffs of it in PRs.