Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #85560

Merged
merged 12 commits into from
May 21, 2021
Merged

Rollup of 4 pull requests #85560

merged 12 commits into from
May 21, 2021

Commits on May 19, 2021

  1. Configuration menu
    Copy the full SHA
    27fe959 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7787bb View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Configuration menu
    Copy the full SHA
    b8909fc View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Configuration menu
    Copy the full SHA
    aee054d View commit details
    Browse the repository at this point in the history
  2. facepalm: operator precedence fail on my part.

    This bug was only visible on mac. Also, print_step_rusage is a relatively new
    internal feature, that is not heavily used, and has no tests. All of these
    factors contributed to how this went uncaught this long. Thanks to Josh Triplett
    for pointing it out!
    pnkfelix committed May 21, 2021
    Configuration menu
    Copy the full SHA
    b3218d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    592fecb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b327aa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e1afc4 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#85506 - GuillaumeGomez:reset-focusedByTab, …

    …r=jsha
    
    Reset "focusedByTab" field when doing another search
    
    Fixes rust-lang#85467.
    
    The problem was simply that we forget to reset the `focusedByTab` field, which was still referring to removed DOM elements.
    
    r? ``@jsha``
    GuillaumeGomez authored May 21, 2021
    Configuration menu
    Copy the full SHA
    51a99eb View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#85548 - GuillaumeGomez:remove-dead-js, r=jsha

    Remove dead toggle JS code
    
    Explanations on how I got there: I randomly saw `adjustToggle` while browsing through code, checked where it was called, put a `debugger;` instruction in it and checked on all pages while playing with settings and toggles. The breakpoint was never triggered. I then looked at `collapseNonInherent` (its grand-parent). In there, the breakpoint was triggered so I look at what was being done and in fact... nothing. So I simply removed it all, re-ran the tests and play with the UI. Everything is working as expected.
    
    Better double check in case I forgot to check a case though, but if nothing has been left out, then it's a great cleanup once again. :)
    
    r? ``@jsha``
    GuillaumeGomez authored May 21, 2021
    Configuration menu
    Copy the full SHA
    3f0bc5c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#85550 - pnkfelix:fix-max-rss-division-on-ma…

    …c, r=Mark-Simulacrum
    
    facepalm: operator precedence fail on my part.
    
    This bug was only visible on mac. Also, print_step_rusage is a relatively new
    internal feature, that is not heavily used, and has no tests. All of these
    factors contributed to how this went uncaught this long. Thanks to Josh Triplett
    for pointing it out!
    GuillaumeGomez authored May 21, 2021
    Configuration menu
    Copy the full SHA
    9ec88ce View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#85555 - LeSeulArtichaut:thir-unsafeck, r=ni…

    …komatsakis
    
    Check for more things in THIR unsafeck
    
    Reunion of rust-lang#85306, rust-lang#85381 and rust-lang#85419 with conflicts resolved.
    r? `@nikomatsakis`
    GuillaumeGomez authored May 21, 2021
    Configuration menu
    Copy the full SHA
    0f48e63 View commit details
    Browse the repository at this point in the history