-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #85560
Rollup of 4 pull requests #85560
Commits on May 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 27fe959 - Browse repository at this point
Copy the full SHA 27fe959View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7787bb - Browse repository at this point
Copy the full SHA d7787bbView commit details
Commits on May 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b8909fc - Browse repository at this point
Copy the full SHA b8909fcView commit details
Commits on May 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aee054d - Browse repository at this point
Copy the full SHA aee054dView commit details -
facepalm: operator precedence fail on my part.
This bug was only visible on mac. Also, print_step_rusage is a relatively new internal feature, that is not heavily used, and has no tests. All of these factors contributed to how this went uncaught this long. Thanks to Josh Triplett for pointing it out!
Configuration menu - View commit details
-
Copy full SHA for b3218d3 - Browse repository at this point
Copy the full SHA b3218d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 592fecb - Browse repository at this point
Copy the full SHA 592fecbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b327aa - Browse repository at this point
Copy the full SHA 6b327aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e1afc4 - Browse repository at this point
Copy the full SHA 0e1afc4View commit details -
Rollup merge of rust-lang#85506 - GuillaumeGomez:reset-focusedByTab, …
…r=jsha Reset "focusedByTab" field when doing another search Fixes rust-lang#85467. The problem was simply that we forget to reset the `focusedByTab` field, which was still referring to removed DOM elements. r? ``@jsha``
Configuration menu - View commit details
-
Copy full SHA for 51a99eb - Browse repository at this point
Copy the full SHA 51a99ebView commit details -
Rollup merge of rust-lang#85548 - GuillaumeGomez:remove-dead-js, r=jsha
Remove dead toggle JS code Explanations on how I got there: I randomly saw `adjustToggle` while browsing through code, checked where it was called, put a `debugger;` instruction in it and checked on all pages while playing with settings and toggles. The breakpoint was never triggered. I then looked at `collapseNonInherent` (its grand-parent). In there, the breakpoint was triggered so I look at what was being done and in fact... nothing. So I simply removed it all, re-ran the tests and play with the UI. Everything is working as expected. Better double check in case I forgot to check a case though, but if nothing has been left out, then it's a great cleanup once again. :) r? ``@jsha``
Configuration menu - View commit details
-
Copy full SHA for 3f0bc5c - Browse repository at this point
Copy the full SHA 3f0bc5cView commit details -
Rollup merge of rust-lang#85550 - pnkfelix:fix-max-rss-division-on-ma…
…c, r=Mark-Simulacrum facepalm: operator precedence fail on my part. This bug was only visible on mac. Also, print_step_rusage is a relatively new internal feature, that is not heavily used, and has no tests. All of these factors contributed to how this went uncaught this long. Thanks to Josh Triplett for pointing it out!
Configuration menu - View commit details
-
Copy full SHA for 9ec88ce - Browse repository at this point
Copy the full SHA 9ec88ceView commit details -
Rollup merge of rust-lang#85555 - LeSeulArtichaut:thir-unsafeck, r=ni…
…komatsakis Check for more things in THIR unsafeck Reunion of rust-lang#85306, rust-lang#85381 and rust-lang#85419 with conflicts resolved. r? `@nikomatsakis`
Configuration menu - View commit details
-
Copy full SHA for 0f48e63 - Browse repository at this point
Copy the full SHA 0f48e63View commit details