Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some backticks to the rustc_middle::ty::adjustment::Adjustment docs #85650

Merged
merged 1 commit into from
May 25, 2021

Conversation

scottmcm
Copy link
Member

A few [i32]s are getting picked up as intra-doc links, rather than showing as slices, making the sentence quite confusing.

See https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/adjustment/struct.Adjustment.html

…docs

A few `[i32]`s are getting picked up as intra-doc links, rather than showing as slices, making the sentence quite confusing.
@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2021
@jyn514
Copy link
Member

jyn514 commented May 25, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 25, 2021

📌 Commit bc2c3dc has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 25, 2021
…jyn514

Add some backticks to the `rustc_middle::ty::adjustment::Adjustment` docs

A few `[i32]`s are getting picked up as intra-doc links, rather than showing as slices, making the sentence quite confusing.

See https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/adjustment/struct.Adjustment.html
This was referenced May 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2021
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#85361 (Use TargetTriple::from_path in rustdoc)
 - rust-lang#85605 (Replace Local::new(1) with CAPTURE_STRUCT_LOCAL)
 - rust-lang#85631 (Move keyword primitive css dom)
 - rust-lang#85644 (Better English for documenting when to use unimplemented!())
 - rust-lang#85650 (Add some backticks to the `rustc_middle::ty::adjustment::Adjustment` docs)
 - rust-lang#85657 (Remove doubled braces in non_exhaustive structs’ documentation text.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aa8c37d into rust-lang:master May 25, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 25, 2021
@scottmcm scottmcm deleted the adjust-adjustment-docs branch May 25, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants